Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random error in test suite from itemgroup tests #60784

Closed
Maleclypse opened this issue Sep 5, 2022 · 2 comments
Closed

Random error in test suite from itemgroup tests #60784

Maleclypse opened this issue Sep 5, 2022 · 2 comments
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S1 - Need confirmation) Report waiting on confirmation of reproducibility Spawn Creatures, items, vehicles, locations appearing on map

Comments

@Maleclypse
Copy link
Member

Describe the bug

ERROR : src/item.cpp:1495 [ret_val item::put_in(const item &, item_pocket::pocket_type, const bool)] tried to put an item (hd_tow_cable) count (1) in a container (backpack) that cannot contain it: pockets unacceptable because item is too long, item is too short, or pocket is holding too much weight6.102 s: shot_features

Steps to reproduce

Run tests hit random seed that tests this itemgroup in this fashion.

Expected behavior

Tests pass

Screenshots

No response

Versions and configuration

current test suite as of 9/5/22

Additional context

No response
@Maleclypse Maleclypse added Good First Issue This is a good first issue for a new contributor (S1 - Need confirmation) Report waiting on confirmation of reproducibility [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels Sep 5, 2022
@mqrause
Copy link
Contributor

mqrause commented Sep 5, 2022

Probably also #59873

@casswedson
Copy link
Contributor

definitely a duplicate of #59873 the comments in the issue point out this exact error in previous ci runs

@mqrause mqrause mentioned this issue Nov 18, 2022
Merged
@mqrause mqrause mentioned this issue Nov 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This is a good first issue for a new contributor [JSON] Changes (can be) made in JSON (S1 - Need confirmation) Report waiting on confirmation of reproducibility Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mqrause @Maleclypse @casswedson