Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divorce splitting vehicles and adding wreckage tag #61304

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Sep 27, 2022

Summary

None

Purpose of change

Fixes #61297
Fixes #58427 - on a limb here, but looks like stuff "behind" the vehicle in the screenshot is a racked vehicle, and likely fake parts were disabled for this vehicle

Any existing vehicles tagged "wreckage" are write-offs unless someone thinks up a method to untag just the non-wrecks...

Building a vehicle starting from a wrecked vehicle also looks to be a way to turn off fake parts for a specific vehicle 🤔

Describe the solution

Change a few functions to move adding "wreckage" tag to wreckage handling, allowing bike racks use vehicle::split_vehicles without applying the tag

Also removes a couple function overloads, used once, added extra code and needed more maintenance than their worth

Describe alternatives you've considered

I'm not sure why wrecks don't get fake parts - it's not possible to repair wrecks into non-wrecks as the flag is permanent for an instance of a vehicle.
Tests pass even if wrecks do get fake parts, considered removing the special casing, but there's no explanation for this in the fake parts PR, so keep on cargo culting.

Testing

Scenario in #61297 works for testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 27, 2022
@irwiss irwiss marked this pull request as ready for review September 27, 2022 16:21
@dseguin dseguin merged commit 8618e52 into CleverRaven:master Sep 29, 2022
@irwiss irwiss deleted the divorce-splitting-and-wreckage-tag branch September 29, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
2 participants