Divorce splitting vehicles and adding wreckage tag #61304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #61297
Fixes #58427 - on a limb here, but looks like stuff "behind" the vehicle in the screenshot is a racked vehicle, and likely fake parts were disabled for this vehicle
Any existing vehicles tagged "wreckage" are write-offs unless someone thinks up a method to untag just the non-wrecks...
Building a vehicle starting from a wrecked vehicle also looks to be a way to turn off fake parts for a specific vehicle 🤔
Describe the solution
Change a few functions to move adding "wreckage" tag to wreckage handling, allowing bike racks use
vehicle::split_vehicles
without applying the tagAlso removes a couple function overloads, used once, added extra code and needed more maintenance than their worth
Describe alternatives you've considered
I'm not sure why wrecks don't get fake parts - it's not possible to repair wrecks into non-wrecks as the flag is permanent for an instance of a vehicle.
Tests pass even if wrecks do get fake parts, considered removing the special casing, but there's no explanation for this in the fake parts PR, so keep on cargo culting.
Testing
Scenario in #61297 works for testing
Additional context