Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching vehicle from bike rack gives carrier vehicle the wreckage tag, disabling gap filling #61297

Closed
DeeUnderscore opened this issue Sep 27, 2022 · 0 comments · Fixed by #61304
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@DeeUnderscore
Copy link
Contributor

Describe the bug

After detaching a carried vehicle from a bike rack, the carrier vehicle acquires the wreckage tag. The consequence is that gap-filling fake parts no longer appear when the carrier vehicle goes diagonal.

Steps to reproduce

  1. Put a bike rack on something like a Luxury RV.
  2. Attach a shopping cart to the bike rack
  3. Drive the RV around, go diagonal, observe fake parts appearing
  4. Detach shopping cart from vehicle
  5. Drive the RV around, go diagonal, no fake parts appear

Expected behavior

Fake parts should appear as long as the vehicle is functional and can move and turn.

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: NixOS; Description: NixOS 22.05 (Quokka); Release: 22.05; Codename: quokka;
  • Game Version: 0.F-11616-gb87b910f87 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food]
    ]

Additional context

Here's saves from before and after removing a shopping cart off a rack. The -after save demonstrates the bug, and you can see the wreckage tag get applied in maps/-2.-6.0/-36.-169.0.map.

The relevant code seems to be in vehicle.cpp, in vehicle::split_vehicles(), called from vehicle::remove_carried_vehicle()

@DeeUnderscore DeeUnderscore added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant