Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles still have gaps #58427

Closed
Griffinhart opened this issue Jun 15, 2022 · 4 comments · Fixed by #61304
Closed

Vehicles still have gaps #58427

Griffinhart opened this issue Jun 15, 2022 · 4 comments · Fixed by #61304
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Griffinhart
Copy link
Contributor

Griffinhart commented Jun 15, 2022

Describe the bug

At least one case of a vehicle having a (LOS) gap still exists after #56143 was merged. See screenshots.

Steps to reproduce

  1. Build 5-wide, 10-long vehicle (see screenshots.)
  2. turn it to face southeast.
  3. Observe gap.

Text description of vehicle construction spec:

  1. Coordinates are given as (row, column), zero-indexed. (0,0) is the northwestern-most tile; (0,4) is the northeastern-most tile; (9,0) is the southwestern-most tile; (9,4) is the southeastern-most tile.
  2. (0,0) -> (0,4) are exterior tiles (rams)
  3. (1,0) -> (1,4) are reinforced windshields
  4. (2,0), (2,4), (6,0), (6,4), and (8,2) are heavy opaque hatches
  5. (2,2) is the driver's seat and controls
  6. (1,3), (3,3), (1,4), (3,4), (1,5), (3,5) are Steel Drum (200L)
  7. (2,3) is an internal door (open in this scenario)
  8. (8,0) -> (8,4), except for (8,2), are heavy stow boards
  9. (3,0) -> (5,0), (3,4) -> (5,4), (7,0), and (7,4) are heavy stow boards
  10. (2,1) -> (7,3) are interior tiles (heavy roof)
  11. (9,0) -> (9,4) are exterior tiles
  12. Wheels are at (1,0), (1,4), (8,0), and (8,4).

Expected behavior

I believe the expectation is that vehicles should not have gaps per #56143.

Screenshots

Gap when vehicle is turned to face southeast:
image

Vehicle construction:
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19044.1706 (21H2)
  • Game Version: 781a1fc [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Blaze Industries [blazeindustries],
    Magiclysm [magiclysm],
    Alternative Map Key [alt_map_key],
    Mythical Martial Arts [MMA],
    Crazy Cataclysm [crazy_cataclysm]
    ]

Additional context

No response

@Griffinhart Griffinhart added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jun 15, 2022
@Griffinhart
Copy link
Contributor Author

Gap also occurs when facing southwest:

image

@Griffinhart
Copy link
Contributor Author

Gap also occurs when facing northwest and northeast.

image

image

@Inglonias
Copy link
Contributor

Can you provide a save file with this vehicle? I would like to try testing this, but unfortunately I'm dumb and cannot read ASCII.

@irwiss
Copy link
Contributor

irwiss commented Sep 27, 2022

@Griffinhart Can you remember if the stuff behind the vehicle on your screenshot was a racked vehicle that you unracked at some point?

Turns out unracking permanently disabled fake parts for all involved vehicles #61297 so these might be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants