Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Portal dungeon work, add enchantments to effects #60161

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Portal dungeon work, add enchantments to effects #60161

merged 5 commits into from
Aug 16, 2022

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Aug 14, 2022

Summary

None

Purpose of change

Part of #58887
Part of #59607 (the c++ and some of the effects)
Add json power and portal dungeon content

Describe the solution

Add switch case to dialog effects
Allow using enchantments on effects
Allow using dialogs with just a topic
Add some new portal dungeon rewards

Describe alternatives you've considered

Testing

to test a portal dungeon correctly do not use the debug weather command. Instead debug run the EOC EOC_CAUSE_PORTAL_STORM and teleport to the quest location

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 14, 2022
@dseguin dseguin merged commit 7fd2da4 into CleverRaven:master Aug 16, 2022
@Ramza13 Ramza13 deleted the switch branch August 16, 2022 15:05
@fungamer2-2 fungamer2-2 mentioned this pull request Aug 19, 2022
Merged
@EIIKaO EIIKaO mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Missions Quests and missions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramza13 @dseguin