'No valid value' in function evalute interacting with computer terminal in evacuee shelter

[akrieger]

Describe the bug

e to interact with the terminal and this debug message pops up. It seems ignorable though.

Steps to reproduce

• Load up the attached save.
• e the terminal. Immediately pops up.

Expected behavior

No debug message on normal interaction.

Screenshots

Versions and configuration

• Win 10
• commit 630e438

Additional context

save.tar.gz
save.zip

[hexagonrecursion]

/confirmed

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 36 (Thirty Six); Release: 36; Codename: ThirtySix;
• Game Version: cee383c [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Growth [no_fungal_growth],
  Bionic Professions [package_bionic_professions]
  ]

 DEBUG    : No valid value.

 FUNCTION : std::__cxx11::string str_or_var<T>::evaluate(const T&) const [with T = dialogue; std::__cxx11::string = std::__cxx11::basic_string<char>]
 FILE     : src/condition.h
 LINE     : 90
 VERSION  : cee383c

[EIIKaO]

It caused by below line; I think it was merged from #60161

Cataclysm-DDA/src/npctalk.cpp

Line 3012 in cee383c

std::string actual_topic = topic.evaluate( d );

Cataclysm-DDA/src/condition.h

Line 90 in cee383c

debugmsg( "No valid value." );

No field in open_dialogue, topic will never be loaded. As a result, evaluate returns a empty string with debug message.

I suppose this debugmsg is useless for everyone( except for debugging ).
One solution is this, should be remove it.
But not sure about removing it without the author's permission.

Another approach is modify json file.

Cataclysm-DDA/data/json/npcs/TALK_COMPUTER.json

Line 5 in cee383c

"effect": [ "open_dialogue" ]

change it to
"effect": { "open_dialogue": { "topic": "COMP_REFUGEE_CENTER_MAIN" } }
then the 'No valid value' error will disappear.

However, this causes a different kind of error([This talker doesn't have a name]), and one that is more repeat again and again than the original one( I assure you that you cannot through it with press the space key ).