Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harmless errors on evac shelter computer #60831

Conversation

EIIKaO
Copy link
Contributor

@EIIKaO EIIKaO commented Sep 7, 2022

Summary

None

Purpose of change

Describe the solution

Inserted check and workaround process before the error arose.

Describe alternatives you've considered

Change the specification of str_or_var<T>.

Testing

  1. Find Evac shelter with a no-damaged computer.
  2. Using that computer, confirm no errors arise.

Additional context

The process of starting with a evac shelter scenario and going to the refugee center is one of the most common playstyles.
I believe that beginners in particular will unconsciously select the evac scenario, because given that it appears at the top of the list of scenarios.
Therefore, I thought we should provide hot fixes to avoid such people being frightened by errors as quickly as possible.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 7, 2022
@dseguin dseguin merged commit 8a34e37 into CleverRaven:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'No valid value' in function evalute interacting with computer terminal in evacuee shelter
2 participants