-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Alchemy #60307
Merged
Merged
[Magiclysm] Alchemy #60307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuardianDll
changed the title
[Magiclysm] Cooking is good for your surviveability
[Magiclysm] Cooking is good for your survivability
Aug 19, 2022
fungamer2-2
reviewed
Aug 19, 2022
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Mods
Issues related to mods or modding
Mods: Magiclysm
Anything to do with the Magiclysm mod
Spawn
Creatures, items, vehicles, locations appearing on map
astyled
astyled PR, label is assigned by github actions
labels
Aug 19, 2022
github-actions
bot
added
the
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
label
Aug 19, 2022
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Aug 19, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 19, 2022
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Need to remove |
github-actions
bot
added
the
Code: Tests
Measurement, self-control, statistics, balancing.
label
Aug 31, 2022
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
* initial commit * forgot to add a teleport rand to loot group * balancing the toxin flask * balance the potion craft time for a bit * added flask of shadows to loot group * typo fixes (i hope) * replacing armor with effects * lint * plural issues * obsolete prof_fine_alchemy * Add NO_EXPLOSION_SFX to clairvoyance * Attempt to balance recipes * grammar fixes * remove necro_basic from known_bad_density
captainego
pushed a commit
to captainego/Cataclysm-DDA
that referenced
this pull request
Oct 9, 2022
* initial commit * forgot to add a teleport rand to loot group * balancing the toxin flask * balance the potion craft time for a bit * added flask of shadows to loot group * typo fixes (i hope) * replacing armor with effects * lint * plural issues * obsolete prof_fine_alchemy * Add NO_EXPLOSION_SFX to clairvoyance * Attempt to balance recipes * grammar fixes * remove necro_basic from known_bad_density
GuardianDll
changed the title
[Magiclysm] Cooking is good for your survivability
[Magiclysm] Alchemy
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Code: Tests
Measurement, self-control, statistics, balancing.
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Implementing more proper alchemy and some another stuff"
Purpose of change
The foundation of alchemy, that someone can use in the future to add their own effects
Describe the solution
adding potions, recipes for them, items, and loot groups to spawn them
Potions effects
common:
potion of illumination - magic flashlight
potion of water breathing - nuff said
mana potions are also here
uncommon:
all magus potions are here, not locked to magus class, and with increased length
potion of iron skin (flask_resistance) - grant some damage resistance
potion of mana reserves (flask_max_mana) - increase your mana pool
"Fire in the flask" (flask_fireball) - magic fireball, literally molotov
"Spear in the flask" (flask_spear) - long, but narrow AoE attack
potion of shadows flask_shadow_field - emit some shadows around the point of cast
rare:
potion of healthiness (flask_healing) good health buff over time
potion of stimul (flask_excitement) - boost some melee stats for a while
potion of regeneration (flask_regeneration) - stretched in time wound healing
potion of mana regeneration (flask_mana_regen) - increase the player's mana regen
potion of escape (flask_teleport_rand) - random targeted teleport
illegal:
potion of instability (flask_confusion) - stun monsters for a while
potion of teleportation (flask_teleport) - teleport to exact position
potion of invisibility (flask_invisibility) - nuff said
potion of domination (flask_charm) - charm picked monster
potion of happiness (flask_mood) - good mood for a long time without drawbacks (yet? i think its pretty rare to have drawbacks, and i believe lot of people will be obesed with it)
potion of toxin (flask_toxin) - short length AoE toxin DoT
potion of venom (flask_venom) - long term targeted toxin DoT
Rewrite the recipes of most another potions
added new books that has recipes of new potions
added loot groups for potions and magic herbs, put herbs in some alchemy related groups
slightly changed another loot groups
changed the Alchemist attunement trap item to have a bigger attack range
moved manatouch serum and mutagen recipes to separate file (they were in the potion recipe file)
Testing
Works almost fine, but require some recipe balancing
Also require a shit ton of proof reading
Additional context
Maybe i need to add some info about it inside the magic balance? 🤔
also HP enchantment is in superposition - it is broken and not broken at the same time: the effect increase your limbs HP, but do not heal you to that body, and do not return HP to previous position, when effect ends