Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Alchemy #60307

Merged
merged 16 commits into from
Oct 5, 2022
Merged

[Magiclysm] Alchemy #60307

merged 16 commits into from
Oct 5, 2022

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 19, 2022

Summary

Mods "Implementing more proper alchemy and some another stuff"

Purpose of change

The foundation of alchemy, that someone can use in the future to add their own effects

Describe the solution

adding potions, recipes for them, items, and loot groups to spawn them

Potions effects

common:
potion of illumination - magic flashlight
potion of water breathing - nuff said
mana potions are also here

uncommon:
all magus potions are here, not locked to magus class, and with increased length
potion of iron skin (flask_resistance) - grant some damage resistance
potion of mana reserves (flask_max_mana) - increase your mana pool
"Fire in the flask" (flask_fireball) - magic fireball, literally molotov
"Spear in the flask" (flask_spear) - long, but narrow AoE attack
potion of shadows flask_shadow_field - emit some shadows around the point of cast

rare:
potion of healthiness (flask_healing) good health buff over time
potion of stimul (flask_excitement) - boost some melee stats for a while
potion of regeneration (flask_regeneration) - stretched in time wound healing
potion of mana regeneration (flask_mana_regen) - increase the player's mana regen
potion of escape (flask_teleport_rand) - random targeted teleport

illegal:
potion of instability (flask_confusion) - stun monsters for a while
potion of teleportation (flask_teleport) - teleport to exact position
potion of invisibility (flask_invisibility) - nuff said
potion of domination (flask_charm) - charm picked monster
potion of happiness (flask_mood) - good mood for a long time without drawbacks (yet? i think its pretty rare to have drawbacks, and i believe lot of people will be obesed with it)
potion of toxin (flask_toxin) - short length AoE toxin DoT
potion of venom (flask_venom) - long term targeted toxin DoT

Rewrite the recipes of most another potions
added new books that has recipes of new potions
added loot groups for potions and magic herbs, put herbs in some alchemy related groups
slightly changed another loot groups
changed the Alchemist attunement trap item to have a bigger attack range
moved manatouch serum and mutagen recipes to separate file (they were in the potion recipe file)

Testing

Works almost fine, but require some recipe balancing
Also require a shit ton of proof reading

Additional context

Maybe i need to add some info about it inside the magic balance? 🤔
also HP enchantment is in superposition - it is broken and not broken at the same time: the effect increase your limbs HP, but do not heal you to that body, and do not return HP to previous position, when effect ends

@GuardianDll GuardianDll changed the title [Magiclysm] Cooking is good for your surviveability [Magiclysm] Cooking is good for your survivability Aug 19, 2022
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels Aug 19, 2022
@github-actions github-actions bot added the Code: Tooling Tooling that is not part of the main game but is part of the repo. label Aug 19, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 19, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2022
@GuardianDll GuardianDll marked this pull request as ready for review August 20, 2022 09:43
@GuardianDll GuardianDll requested a review from KorGgenT as a code owner August 20, 2022 09:43
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Concentrated potion, teleported right in the enemie's body - fast, painful, and guarantee death.
  • Important part of every professional robber. It was banned by the goverment due the popularity in crime sphere, but some people still know the recipe.
  • Make you totally invisible, except in mana spectrum. It was banned by the goverment due the popularity in crime sphere, but some people still know the recipe.
  • One of the various potions, designed to make person stronger on batte field. Increase the user's senses and improve the reaction, increasing his ability to fight in melee.
  • Rearrange neural activity of the creature to be 100% loyal to a blood owner. It was banned by the goverment due the popularity in crime sphere, but some people still know the recipe.
  • That thing temporary freeze the high brain activity for a while. It was banned by the goverment due the popularity in crime sphere, but some people still know the recipe.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Fris0uman
Copy link
Contributor

Need to remove necro_basic from TEST_DATA/known_bad_density.json

@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Aug 31, 2022
@Fris0uman Fris0uman merged commit d65876a into CleverRaven:master Oct 5, 2022
@GuardianDll GuardianDll deleted the alchemy branch October 5, 2022 10:00
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
* initial commit

* forgot to add a teleport rand to loot group

* balancing the toxin flask

* balance the potion craft time for a bit

* added flask of shadows to loot group

* typo fixes (i hope)

* replacing armor with effects

* lint

* plural issues

* obsolete prof_fine_alchemy

* Add NO_EXPLOSION_SFX to clairvoyance

* Attempt to balance recipes

* grammar fixes

* remove necro_basic from known_bad_density
captainego pushed a commit to captainego/Cataclysm-DDA that referenced this pull request Oct 9, 2022
* initial commit

* forgot to add a teleport rand to loot group

* balancing the toxin flask

* balance the potion craft time for a bit

* added flask of shadows to loot group

* typo fixes (i hope)

* replacing armor with effects

* lint

* plural issues

* obsolete prof_fine_alchemy

* Add NO_EXPLOSION_SFX to clairvoyance

* Attempt to balance recipes

* grammar fixes

* remove necro_basic from known_bad_density
@GuardianDll GuardianDll changed the title [Magiclysm] Cooking is good for your survivability [Magiclysm] Alchemy Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants