-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Update 6 #57558
Merged
dseguin
merged 12 commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register-7
May 10, 2022
Merged
Store Update 6 #57558
dseguin
merged 12 commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register-7
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cash register, concrete back alley
cash register, concrete back alley
cash register, sidewalk
cash register, sidewalk, regional terrain, counter gate
cleanup, regional terrain, cash register, linoleum kitchen and toilet, fix incorrect terrain
concrete floor, cash register, cleanup, more used furniture
linoleum floor, cleanup, cash register
vehicle variety, cash register, nested tents
cash register, concrete floor
cash register, concrete back alley
cash registers, linoleum toilet
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
May 8, 2022
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Updates some stores"
Purpose of change
Code from #57493, relies on #57523
To add cash registers to shops & stores and to update their mapgen.
Describe the solution
place_items
rows, linoleum floors for toilets and kitchen, added counter gate, fixed incorrect terrain under furnitureDescribe alternatives you've considered
None.
Testing
Visited every location that was affected by this PR. And then a few more times. Cash registers spawn as intended, and obvious mapgen errors (most likely) are fixed.
Additional context