Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Update 6 #57558

Merged
merged 12 commits into from
May 10, 2022
Merged

Store Update 6 #57558

merged 12 commits into from
May 10, 2022

Conversation

LovamKicsiGazsii
Copy link
Contributor

Summary

Content "Updates some stores"

Purpose of change

Code from #57493, relies on #57523
To add cash registers to shops & stores and to update their mapgen.

Describe the solution

  • gaming store: added cash registers
  • gun store: added cash registers
  • hunting supply store: added cash registers, added counter gate, added a pathway to the sidewalk
  • sporting goods store: added cash registers, replaced wooden floor with concrete, added regional terrain, added a pathway to the sidewalk
  • teashop: added cash registers, simplified mapgen, cut back on place_items rows, linoleum floors for toilets and kitchen, added counter gate, fixed incorrect terrain under furniture
  • thrift store: added cash registers, added regional terrain, replaced wooden floor with concrete, more variety in second-hand furniture
  • veterinarian clinic: added cash registers, concrete back alley
  • **home improvement superstore: added cash registers, fixed damaged tents, more vehicle variety
  • home improvement store: added cash registers, replaced wooden floor with concrete, added regional terrain
  • electronics store: added cash registers, concrete back alley
  • clothing store: added cash registers, linoleum floor under toilets, replaced rack with clothing lines

Describe alternatives you've considered

None.

Testing

Visited every location that was affected by this PR. And then a few more times. Cash registers spawn as intended, and obvious mapgen errors (most likely) are fixed.

Additional context

kép
kép
kép

cash register, concrete back alley
cash register, concrete back alley
cash register, sidewalk
cash register, sidewalk, regional terrain, counter gate
cleanup, regional terrain, cash register, linoleum kitchen and toilet, fix incorrect terrain
concrete floor, cash register, cleanup, more used furniture
linoleum floor, cleanup, cash register
vehicle variety, cash register, nested tents
cash register, concrete floor
cash register, concrete back alley
cash registers, linoleum toilet
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 8, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 9, 2022
@dseguin dseguin merged commit b072194 into CleverRaven:master May 10, 2022
@LovamKicsiGazsii LovamKicsiGazsii deleted the cash-register-7 branch May 10, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants