-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cash registers #57523
Merged
dseguin
merged 17 commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register-only
May 9, 2022
Merged
Cash registers #57523
dseguin
merged 17 commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register-only
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+removed console
+ regional terrain
+regional terrain
+ regional terrain
+ removed console, added regional terrain
+ removed console
+ removed some consoles
+removed some consoles, regional terrain
+regional terrain
+fixed vending machine errors
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Containers
Things that hold other things
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods
Issues related to mods or modding
Mods: No Hope
Relating to the mod No Hope
Spawn
Creatures, items, vehicles, locations appearing on map
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
May 7, 2022
Could you add a disassembly recipe for it as well? |
Merged
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
May 7, 2022
github-actions
bot
added
the
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
label
May 7, 2022
This was referenced May 8, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items: Containers
Things that hold other things
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: No Hope
Relating to the mod No Hope
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Cash registers"
Purpose of change
Code from #57493
Immersion. Since we have coins, banknotes, ATMs, and wallets in-game, I figured we should have cash registers as well.
Describe the solution
This PR adds the cash register item, item groups related to cash registers, and the locations where I only added cash registers ( + replaced consoles, added pseudo terrains )
Locations changed: Glassblower's, abandoned storefront, antique store, arcade, art gallery, sex shop, garage with gas station, megastore ( + No_Hope version ), regional airport, medium storage units, large storage units
Describe alternatives you've considered
None.
Testing
Visited every location that was affected by this PR. And then a few more times.
Additional context
Screenshots:
Megastore