Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cash registers ( and much more ) #57493

Closed
wants to merge 78 commits into from
Closed

Cash registers ( and much more ) #57493

wants to merge 78 commits into from

Conversation

LovamKicsiGazsii
Copy link
Contributor

@LovamKicsiGazsii LovamKicsiGazsii commented May 6, 2022

Summary

Content "Cash registers"

Purpose of change

Immersion. Since we have coins, banknotes, ATMs, and wallets in-game, I thought we should have cash registers as well.
While I was adding cash registers into stores and other suitable locations, I figured I might as well make minor changes to their mapgen.

Describe the solution

Aside from making cash registers and having them spawn somewhere, I also fixed a few errors in the mapgen and gave some older buildings a facelift.

  • I've replaced some terrains with their regional (pseudo) counterparts
  • Toilets and kitchens, butcher shops, and pharmacies were given linoleum flooring
  • Some stores were given concrete floors ( like bike shops and sporting goods stores )
  • Fixed incorrect terrain under furniture in a few locations
  • Increased loot in paintball fields, thrift stores, and dispensaries
  • Furnished the back area of dispensaries
  • Merged maps in motel.json, added pools and parking lots
  • Added toilets and vehicles to road stops
  • Tried to make files a bit more readable, removed null furniture, added fill_ter, substituted lots of place_items rows with items, used spaces to describe outside terrain in some files
  • Fixed tents in home improvement megastores
  • Replaced wood walls with privacy fences in motel-twd and s_restaurant_fast_1
  • Replaced fence gates with counter gates at the coffee shops
  • Added counter gates to a few locations

Describe alternatives you've considered

Narrowing down the scope of this PR.

Testing

Visited every location that was affected by this PR. And then a few more times.

Additional context

Screenshots:

kép
Not sure how accurate this actually is. I based it on 'SHARP XE-A137'.
kép

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 6, 2022
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: No Hope Relating to the mod No Hope BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 6, 2022
@cainiaowu
Copy link
Contributor

Yeah, this is way too big for one PR, you need to split this into multiple parts.
The solution could be one at a time.

This was referenced May 7, 2022
@LovamKicsiGazsii LovamKicsiGazsii deleted the cash-register branch May 8, 2022 15:14
@omni-Var
Copy link

Amazing efforts, wow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants