-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cash registers ( and much more ) #57493
Closed
LovamKicsiGazsii
wants to merge
78
commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register
Closed
Cash registers ( and much more ) #57493
LovamKicsiGazsii
wants to merge
78
commits into
CleverRaven:master
from
LovamKicsiGazsii:cash-register
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Containers
Things that hold other things
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Spawn
Creatures, items, vehicles, locations appearing on map
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
May 6, 2022
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: No Hope
Relating to the mod No Hope
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
May 6, 2022
Yeah, this is way too big for one PR, you need to split this into multiple parts. |
This was referenced May 8, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Amazing efforts, wow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Containers
Things that hold other things
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: No Hope
Relating to the mod No Hope
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Cash registers"
Purpose of change
Immersion. Since we have coins, banknotes, ATMs, and wallets in-game, I thought we should have cash registers as well.
While I was adding cash registers into stores and other suitable locations, I figured I might as well make minor changes to their mapgen.
Describe the solution
Aside from making cash registers and having them spawn somewhere, I also fixed a few errors in the mapgen and gave some older buildings a facelift.
motel.json
, added pools and parking lotsfill_ter
, substituted lots ofplace_items
rows withitems
, used spaces to describe outside terrain in some filesmotel-twd
ands_restaurant_fast_1
Describe alternatives you've considered
Narrowing down the scope of this PR.
Testing
Visited every location that was affected by this PR. And then a few more times.
Additional context
Screenshots:
Not sure how accurate this actually is. I based it on 'SHARP XE-A137'.