Declutter inventory UIs

[andrei8l]

Summary

None

Purpose of change

Pickup menu is typically cluttered with useless entries such as pen ink, duplicated information such as ammo counts, and this fugly hidden marker at the end of collapsed items.
#56427 included a ham-handed fix that unconditionally hid all items inside magazines and was not well received
Closes: #56621
Invalidates (mostly): #53437

Describe the solution

1. show items in magazines again with a preset switch
2. allow collapsing magazines too instead of just container pockets
3. collapse all magazines by default (for new items only). You can still quickly select the contents by filtering for ammo, etc (ex: c:ammo)
4. only show the hidden marker for collapsed container pockets

Describe alternatives you've considered

instead of 1: include that functionality in inv_sel_preset::is_shown() instead. That needs a lot of boilerplate...
instead of 3: add COLLAPSE_CONTENTS to all the items whose default contents are subjectively useless. This is a lot of churn for the same effect
instead of 4: replace the marker with a red +. I haven't found any case where that information would be useful outside of inventory_selector. It's a minor change though if it turns out to be needed.

Testing

before #56427

Item names are sometimes improperly expanded

after this patch

Chevron isn't shown if the contents aren't allowed by the preset

(from player inventory window)

Nested magazines aren't expanded anymore:

The backpack/harness was collapsed manually and all the other items were newly spawned.

Additional context

Astyle really doesn't know how to break lines nicely.

[PatrikLundell]

I dislike the removal of the hidden indicator, as you now can chase around the UI to locate the blasted items that are in a container where it doesn't belong, but not find them because they're hidden. I want to be told specifically that the stuff in some containers are actually suppressed from view, rather than have the (new) player guess that you probably can't see items in first aid kits and wallets, but find that you can see them in STEM kits and the like.

Also, the testing images show only dedicated container type items, not "normal" containers, such as a box of toast-ems and a box of toast-ems where the pickup logic has also crammed e.g. a bottle of beer into the box. I assume those are intended to be unchanged, but it would be nice to verify that this actually is the case.

[Zireael07]

I agree that removing the indicator isn't a good step.

[Theawesomeboophis]

Is this optional, as I personally like the old Ui more as it contains more information.

[andrei8l]

I want to be told specifically that the stuff in some containers are actually suppressed from view

I agree that removing the indicator isn't a good step.

Isn't the chevron enough? It's pointing the wrong way (compared to here on github), but it also shows the key needed to uncollapse the item

and I don't want to mess with people's muscle memory

I could also add a keybinding hint in this block of text maybe

as you now can chase around the UI to locate the blasted items that are in a container where it doesn't belong,

Items that match the filter will show up even if hidden, since #53444

Is this optional, as I personally like the old Ui more as it contains more information.

Sorry, I can't make it optional with the current implementation of collapsing, unless I give up on saving the collapsed status. (EDIT: well I probably can, but it's looking pretty ugly and needs a global option). I don't think the old behavior gives you any extra information

red pen ink is written twice and you can't even interact directly with the second one. You can always uncollapse the red pen if you really want as this PR only changes the default status (and makes it possible to change in the first place for magazines).

[andrei8l]

I've re-added the hidden marker, but only for container pockets and inline with the rest of the text

[mqrause]

I like the chevron myself, maybe it's enough to put a bit more emphasis on it? Or instead of the hidden marker, a different text/background color for the entry could also be an option. The goal should be to be able to tell on a glance that an entry is collapsed, and having to actually read a word for that, which can be in different places so you have to read even more words to find it, doesn't do that well in my opinion.

[andrei8l]

I can use full black triangles for the chevrons

which should be more intuitive because this style is used literally everywhere, but it doesn't look so great when the contents are in a different column:

or aren't shown at all due to the preset:
I don't immediately see a good solution for these.

[mqrause]

I like that. I'd consider placing it in front of the invlet, but I'm not entirely sure about that.

it doesn't look so great when the contents [...] aren't shown at all due to the preset:

Ideally it doesn't even get treated as a container in such cases.

[Theawesomeboophis]

I want to be told specifically that the stuff in some containers are actually suppressed from view

I agree that removing the indicator isn't a good step.

Isn't the chevron enough? It's pointing the wrong way (compared to here on github), but it also shows the key needed to uncollapse the item
I could also add a keybinding hint in this block of text maybe

as you now can chase around the UI to locate the blasted items that are in a container where it doesn't belong,

Items that match the filter will show up even if hidden, since #53444

Is this optional, as I personally like the old Ui more as it contains more information.

Sorry, I can't make it optional with the current implementation of collapsing, unless I give up on saving the collapsed status. (EDIT: well I probably can, but it's looking pretty ugly and needs a global option). I don't think the old behavior gives you any extra information red pen ink is written twice and you can't even interact directly with the second one. You can always uncollapse the red pen if you really want as this PR only changes the default status (and makes it possible to change in the first place for magazines).

Oh, so I can still get all the info by uncollapsing the item? What I was talking about was the gun magazine not appearing, just realized second photo is collapsed, this seems like a great change now that I realized what it actually does, sorry for the confusion.

[andrei8l]

I've fixed it so that the chevron only shows if the item's contents aren't hidden by the preset.

[andrei8l]

Thanks for merging.