inventory_selector: clean up deprecated code #56427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
There's a lot of confusing, deprecated code in
inventory_ui
.Items gets stacked and moved around for no good reason several times.
Items in a trader's inventory gets sorted under "Items Worn" instead of categorizing correctly (the bug I was trying to fix!)
Describe the solution
Spank deprecated and/or duplicated code.
Put the items in the right columns/categories instead of moving them with
toggle_categorize_contained()
after building the list.Describe alternatives you've considered
N/A
Testing
Every UI based on
inventory_selector
(inventory, eat, multidrop, unload, activate, pickup, compare, etc) should look and function exactly the same as before with these 3 changes:Additional context
N/A