Hide bullets and magazines in guns when character wielding items

[wwkk222208]

Summary

Features "Hide bullets and magazines in guns when character wielding items"

Purpose of change

When the player finds a new gun, he might:

1. wield this gun
2. pick it up
3. unload it and pick bullets or the magazin up.

But he is not likely to wield a magazine or bullets.

In current game, magazines and bullets in guns are hidden by default in 'Inventory' and displayed in 'Wield item' and 'Pick up'. It is more reasonable to hide them in 'Wield item'.
This change can make the window more concise.

Describe the solution

Hide magazines and bullets in guns when the character attempt to wield something just like how they behave in Inventory window.

Describe alternatives you've considered

Testing

This feature is successfully implemented.

Additional context

[andrei8l]

It'd be better to set magazine and ammo pockets to be collapsed by default, but that needs a few more changes: start by adding a pocket filter to {item,item_contents}::get_all_contained_pockets(), then update the couple of places that handle collapsed pockets - let me know if you want to do this and need help.

[NetSysFire]

Consider not using SUMMARY: None for this PR as this is a noteworthy change imo.

[wwkk222208]

It'd be better to set magazine and ammo pockets to be collapsed by default, but that needs a few more changes: start by adding a pocket filter to {item,item_contents}::get_all_contained_pockets(), then update the couple of places that handle collapsed pockets - let me know if you want to do this and need help.

If set magazine and ammo pockets to be collapsed by default, they will also be hidden in the pick up window. I consulted a friend of mine who felt it necessary to show them in the pick up window. Players often want to directly pick up ammunition or magazines instead of guns. Maybe I should find out what other people think of this issue.
In addition, get_all_contained_pockets() does not seem to be applicable to this issue, because this function will only retrieve pockets of the container type.

[wwkk222208]

Consider not using SUMMARY: None for this PR as this is a noteworthy change imo.

Thanks for your suggestion.

[I-am-Erk]

I think the solution here is to collapse them by default, or at least collapse them automatically when wielded. That way they still follow the rules of other containers. Having them follow their own special rule is likely to be confusing

[wwkk222208]

I think the solution here is to collapse them by default, or at least collapse them automatically when wielded. That way they still follow the rules of other containers. Having them follow their own special rule is likely to be confusing

The magazine well is not regarded as a container, so some additional code is needed to implement this feature in this way.
This PR will remain as a draft until this it is completed,

[wwkk222208]

The magazines are intentionally hidden in ‘Inventory’. If we allow the player to set whether the magazine is hidden without changing this setting, it will be confusing. I am not sure if it can be modified.

[I-am-Erk]

If the magazines already behave that way, there's no need to change them. I just don't want their behaviour to change when they're wielded.

[wwkk222208]

If the magazines already behave that way, there's no need to change them. I just don't want their behaviour to change when they're wielded.

In the current game, the magazine is displayed in ‘pick up’ and ‘wield item’ and hidden in ‘inventory’, which is also somewhat confusing.(Many people try to wield a gun but get a magazine. lol..)

In terms of practicality of gameplay, it is more reasonable for the magazine to be displayed in the ‘pick up’ and to be hidden in the ‘wield item’ and ‘inventory’.

In terms of consistency, the magazine should be hidden/displayed in ‘pick up’, ‘wield item’ and ‘inventory’ at the same time as the player decides.

In terms of reality, hide it directly in all windows just like how it behaves in 'inventory'. Players can only get them through ‘unload’, which is reasonable to some extent.

Which one do you think is more reasonable?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[stale]

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it