Fix feeding fires from a firewood source #47092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the negated boolean variable `no_fire` to `have_fire` and un-negate its usage. Make `have_fire` default true, so `player_activity::do_turn` will check for the presence of fire at least once.
BrettDong
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix feeding fires from a firewood source"
Purpose of change
Fix #47008
Describe the solution
Rename
no_firetohave_fire, and un-negate its usage. Defaulthave_fireto true, soplayer_activity::do_turnwill try feeding the fire at least once after it is lit (and will sethave_fireto false only if there is in fact no fire to feed).Describe alternatives you've considered
Renaming the variable isn't strictly necessary but I think improves overall clarity.
Testing
See original issue
Additional context
Successfully keeping a fire going with splintered wood:
