folding bicycle is dead. Long live Folding Bicycle

[hexagonrecursion]

Summary

SUMMARY: Bugfixes "Reimplement folding bicycle as a regular foldable vehicle that follows the same rules as the rest"

Purpose of change

Fixes #46752
Fixes #28976
Fixes #39399

Folding bicycle was a flodable vehicle before flodable vehicles were implemented. Now we have a more general foldable vehicle system, but we are still keeping folding bicycle as a special case which follows different rules. It is time to reimplement folding bicycle as a regular foldable vehicle.

Describe the solution

• reimplement or remove content that references "folding_bicycle"
• add migration code to replace the folding_bicycle item in save files with the new version
• add migration code to replace the folding bicycle vehicle in save files with the new version

Describe alternatives you've considered

• leave everything as is
• implement migration of saves by replacing unfolding code for the folding_bicycle item. This would not fix Foldable bike can't be folded after unloaded from bike racks #28976 and item stats would have to be manually kept in sync

Testing

none yet

Additional context

none

[hexagonrecursion]

As far as I know there is unfortunately no way to reference a folded version of a vehicle from inside an item group and implementing one would probably be more effort than it is worth. So far I simply deleted the entry from item groups. Not sure what to replace this content with.

[hexagonrecursion]

All that is left it on the C++ side:

• cleanup dead code
• implement save migration (since jsonized migration is probably not flexible enough)

[hexagonrecursion]

Yes. Definitely not flexible enough

Cataclysm-DDA/src/item_factory.h

Lines 43 to 62 in 0d85973

	class migration
	{
	public:
	itype_id id;
	itype_id replace;
	std::set<std::string> flags;
	int charges = 0;
	class content
	{
	public:
	itype_id id;
	int count = 0;
	bool operator==( const content & ) const;
	void deserialize( JsonIn &jsin );
	};
	std::vector<content> contents;
	bool sealed = true;
	};

[int-ua]

I think I mislabeled the issue as a Good first issue. It's far from trivial.

[Rivet-the-Zombie]

As far as I know there is unfortunately no way to reference a folded version of a vehicle from inside an item group and implementing one would probably be more effort than it is worth. So far I simply deleted the entry from item groups. Not sure what to replace this content with.

So this PR prevents folding bicycles from spawning outside of a single profession's starting inventory?

[hexagonrecursion]

So this PR prevents folding bicycles from spawning outside of a single profession's starting inventory?

Good point. I should make the unfolded version spawn randomly somewhere.

[hexagonrecursion]

I think I mislabeled the issue as a Good first issue. It's far from trivial.

The hardest part is meeting my archenemy - c++ compilers and not running away screaming like a little girl.

[hexagonrecursion]

• add migration code to replace the folding_bicycle item in save files with the new version
• add migration code to replace the folding bicycle vehicle in save files with the new version

I came up with a simpler solution:

• remove the ability to fold the folding bicycle vehicle
• make the folding_bicycle item disassemble into parts that you can build your own folding bicycle

This has the downside of breaking existing folding bicycles, but the upside is less code to maintain.

[ZhilkinSerg]

Let's move it post-0.F

[Night-Pryanik]

@hexagonrecursion is this still being worked on?

[hexagonrecursion]

No. Sorry. Anyone, fell free to pick this up.