Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foldable bike can't be folded after unloaded from bike racks #28976

Closed
vivi00790 opened this issue Mar 25, 2019 · 4 comments · Fixed by #59572
Closed

Foldable bike can't be folded after unloaded from bike racks #28976

vivi00790 opened this issue Mar 25, 2019 · 4 comments · Fixed by #59572
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@vivi00790
Copy link

As title, after unloaded foldable bike from bike racks, it became a normal bike that can't be folded when 'e'xamine it.

To Reproduce

  1. Unfold the folded bike.
  2. Load it on bike racks.
  3. Unload it in bike racks.
  4. Examine it to see whether there's an option to fold it.

Expected behavior
It should be foldable after unload.

Versions and configuration(please complete the following information):

  • OS:
    image
  • Game Version: 0.D-947-g980ca05
  • Graphics version: Tiles
  • Mods loaded:
    image
    image
    image
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed (S1 - Need confirmation) Report waiting on confirmation of reproducibility Vehicles Vehicles, parts, mechanics & interactions labels Mar 25, 2019
@RobynLlama
Copy link

RobynLlama commented Mar 25, 2019

Reproduced on 0.D-981-g22eeef9 (tiles).

I think the reason here is that the folding bike uses extra-light frames as all three of its frame components which lack the folding tag. Attaching and then removing it from another vehicle causes it to lose "tags": [ "convertible", "convertible:folding_bicycle"] and lacking the proper folding frames it becomes unable to be folded

Solution:
Use a new vehicle for the folding bike that has folding light frames in place of extra-light frames -or-
Change the way vehicles are merged by bike racks to somehow prevent losing the convertible tags but also disallow the merged vehicle to be folded into a folding bike

@adamkad1
Copy link
Contributor

or make the folding bike actually be made from folding parts?

@RobynLlama
Copy link

Crunchepillar: Use a new vehicle for the folding bike that has folding light frames in place of extra-light frames
That's the only part of the folding bike that isn't folding so, yea, kinda already in my suggested fixes. When I say "Use a new vehicle for the folding bike" I mean make the folding bike (item) spawn a vehicle that can be correctly folded rather than a standard bike with the convertible tags added. Sorry if I didn't make that very clear.

@int-ua int-ua removed the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 14, 2021
@int-ua
Copy link
Contributor

int-ua commented Jan 14, 2021

Please verify it on the latest experimental release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
5 participants