Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the foldable bicycle special item with a generic folding vehicle #46752

Closed
int-ua opened this issue Jan 15, 2021 · 1 comment · Fixed by #59572
Closed

Replace the foldable bicycle special item with a generic folding vehicle #46752

int-ua opened this issue Jan 15, 2021 · 1 comment · Fixed by #59572
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing Vehicles Vehicles, parts, mechanics & interactions

Comments

@int-ua
Copy link
Contributor

int-ua commented Jan 15, 2021

Is your feature request related to a problem? Please describe.

Folding vehicles are now possible to create in the standard vehicle interface, no need to have this separate item that has accumulated two major issues: #28976 and #39399

@BevapDin comment:

The whole folding bicycle item should go away. It is either inconsistent or redundant:

It's inconsistent because it creates (when unfolded) a vehicle that could have been made via the vehicle interface (frames, saddle, wheels, etc.) However, making the item requires different tools / tool charges and different time than making the vehicle.

Fixing that inconsistency (which may get unfixed as soon as somebody changes the vehicle part installation settings), would make the item redundant. One can instead just make a vehicle and fold that. Why make an item, if it takes the same resources?

Therefor it should be removed.

Note that vehicles creates via the vehicle interface can be made with special properties (someone might want a bicycle with a horn, different cargo part, different wheels ...)

Describe the solution you'd like

Folding bicycle replaced with similar vehicle, not special item.

Describe alternatives you've considered

Additional context

@int-ua int-ua added <Suggestion / Discussion> Talk it out before implementing Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact Vehicles Vehicles, parts, mechanics & interactions labels Jan 15, 2021
@int-ua int-ua changed the title Replace the foldable bicycle special item Replace the foldable bicycle special item with a generic folding vehicle Jan 15, 2021
@int-ua int-ua removed the Good First Issue This is a good first issue for a new contributor label Jan 17, 2021
@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
1 participant