Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported 0.E fixes #41325

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Backported 0.E fixes #41325

merged 5 commits into from
Jun 18, 2020

Conversation

int-ua
Copy link
Contributor

@int-ua int-ua commented Jun 15, 2020

Summary

SUMMARY: Bugfixes "Backported some fixes to 0.E"

Describe the solution

Original PRs are mentioned in both commit messages.

Testing

Hirmuolio commits tested and look good, Qrox changes not tested by me.

@int-ua int-ua changed the title [WIP] Two fixes backported to 0.E [CR] Two spoilage fixes backported to 0.E Jun 15, 2020
@Qrox
Copy link
Contributor

Qrox commented Jun 15, 2020

While you're at it can you also backport #39405 and #40025 to 0.E?

@int-ua int-ua changed the title [CR] Two spoilage fixes backported to 0.E [CR] Backported 0.E fixes Jun 15, 2020
@int-ua
Copy link
Contributor Author

int-ua commented Jun 15, 2020

@Qrox Done. How does it look? No testing yet, obviously.

@int-ua int-ua changed the title [CR] Backported 0.E fixes [WIP][CR] Backported 0.E fixes Jun 16, 2020
@mlangsdorf mlangsdorf added the <Bugfix> This is a fix for a bug (or closes open issue) label Jun 17, 2020
@int-ua
Copy link
Contributor Author

int-ua commented Jun 17, 2020

Tested Hirmuolio commits, they look good. @Qrox can you confirm yours will work on 0.E?

@int-ua int-ua changed the title [WIP][CR] Backported 0.E fixes Backported 0.E fixes Jun 17, 2020
@anothersimulacrum anothersimulacrum added the [C++] Changes (can be) made in C++. Previously named `Code` label Jun 17, 2020
@Qrox
Copy link
Contributor

Qrox commented Jun 18, 2020

Sure, I'll test when I have time.

@kevingranade kevingranade merged commit 61c1096 into CleverRaven:0.E-branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants