Update string extraction script and fix computer translation #39405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qrox
changed the title
ZhilkinSerg
added
<Bugfix>
Merged
kevingranade
pushed a commit
that referenced
this pull request
Jun 18, 2020
…ranslation Co-authored-by: Qrox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: I18N "Fix translation of martial art initate message and computer translation"
Purpose of change
Extract martial art initiate message and fix translation of computer strings. Fixes #39290.
Describe the solution
Added missing json object types to the extraction script, suppressed an error when mutation definition copies from another definition and does not specify the name, and extracted martial art initate message.
Also, It now reads computer mapgen strings using
translation.Testing
Ran
lang/update_pot.shand martial art initiate messages were correctly extracted. Computer strings were also correctly translated.Additional context
Maybe we should backport it to 0.E after the new strings are translated.