[CR] Skip unnecessary weather calculations for root cellar

[int-ua]

Summary

SUMMARY: Performance "Skip unnecessary weather calculations for root cellar"

Describe the solution

Checking for root cellar in item::process_temperature_rot in addition to pos.z and avoiding weather for it.

Additional context

Old description follows:

---

Summary

SUMMARY: Bugfixes "Equalize root cellar and underground spoilage rates"

Purpose of change

#24083 description gives impression that root cellars must be equivalent to storing food underground yet they were not exactly equal.

Describe the solution

Checking for root cellar in item::process_temperature_rot in addition to pos.z. This change was ported from my local fork of 0.E branch.

Testing

Only on my 0.E local branch. It worked as intended there.

Additional context

https://discourse.cataclysmdda.org/t/spoilage-in-root-cellars-is-faster-than-underground-z-1/23956

[Hirmuolio]

The root cellar temperature is applied few lines later at https://github.com/CleverRaven/Cataclysm-DDA/blob/master/src/item.cpp#L8718
So adding this check shouldn't change anything (unless I am missing something). Though it would skip the weather calculations that are not needed for root cellars so maybe minor performance increase.

Root cellar items should rot at same rate as underground items. If that is not the case it should be investigated.

Items spawned from mapgen have some random variance in their initial rot level (IIRC +-20%) so you should test with items spawned from debug menu.
Enabling debug mode displays exact rot value and temperature in the item info.

[int-ua]

applied few lines later

I thought so too at first, but it looks like it's the other way around: underground gets treated differently and therefore has lower total temperature. I tested with wished-for items both before the change and after in the same way. And before the change items spoiled a bit faster in root cellar while after it they spoiled at exactly* the same rate. But yes, I don't fully understand how it works yet.

exact rot value and temperature

Didn't notice it, I'll re-test tomorrow again if it's not yet clear by that point.

[*] I noticed differences of +- several turns only.

[Hirmuolio]

Edit: Disregard this. My test world had its time set to before start of game which makes items behave in very strange ways.

Edit 2: Tested with proper world. Yeh root cellar did nothing. Item on ground and item in root cellar had same rot value after 2d off map.

[int-ua]

Oh, I forgot that my fork that I tested it on had your ice lab fix that I had to backport because it was omitted in 0.E-# updates for some reason despite me mentioning only that change in request for 0.E updates on Discord. Not sure if it affected anything. Can't test right now but I'm on #CDDA-Dev IRC channel if you have some interesting details to share real-time.

[Hirmuolio]

Found the problem

When map is loaded (player returns from far away location) the item gets processed without the temperature flag.

[int-ua]

I'll re-purpose this PR as just an optimization.

[Maleclypse]

Is this PR ready for review?