Fix item_location (de)serialization handling #35593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write a null item location if we failed to unpack the character pointer to avoid invalid json. Assume g->u was the character if there is no character field on deserialization since all character item locations were on g->u before the character field was introduced.
ifreund
added
[C++]
|
Issue with old worlds where an NPC is reading. On the turn they increase their skill there's a CTD. No biggie, just tell them to stop reading. In case anybody else gets this (rare) issue any time soon. Brilliant job fixing this so quickly! 👍 |
|
Thanks! I am the one who caused the issue after all... Sounds like that CTD is actually a leftover manifestation of the original issue #35352. Not really anything that could be done about in progress reading activities unfortunately, but any new ones should go smoothly. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix item_location (de)serialization handling"
Purpose of change
Fixes #35584
Describe the solution
pointer to avoid invalid json.
deserialization since all character item locations were on g->u
before the character field was introduced.
Testing
Saves from before 8d5b04e can be loaded without error with these changes