Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save breaking bug on build 9908 #35584

Closed
RDru opened this issue Nov 18, 2019 · 4 comments · Fixed by #35593
Closed

Save breaking bug on build 9908 #35584

RDru opened this issue Nov 18, 2019 · 4 comments · Fixed by #35593
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world (P2 - High) High priority (for ex. important bugfixes) (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@RDru
Copy link
Contributor

RDru commented Nov 18, 2019

Describe the bug

on saving:

 DEBUG    : Failed to find item_location owner with character_id -1

 FUNCTION : bool item_location::impl::item_on_person::ensure_who_unpacked() const
 FILE     : src/item_location.cpp
 LINE     : 240

then on loading:

 DEBUG    : Bad save json
line 23:1684994: expecting string but found ':'

rges": 1, "bday": 14758492, "owner": "NULL", "old_owner": "NULL", "item_tags": [ "CASING" ], "relic_data": null } ], "relic_data": null }, "last_target_pos": null, "destination_point": null, "faction_warnings": [  ], "ammo_location": "camps":
                                                                                                                                                                                                                                                ^
                                                                                                                                                                                                                                                  [  ], "profession": "bionic_installer", "scenario": "cyberpunk", "controlling_vehicle": false, "grab_point": [ 0, 0, 0 ], "grab_type": "OBJECT_NONE", "focus_pool": 56, "str_upgrade": 1, "dex_upgrade": 2, "int_upgrade": 1, "per_upgrade": 4,


 FUNCTION : void game::unserialize(std::istream&)
 FILE     : src/savegame.cpp
 LINE     : 245

Steps To Reproduce

Steps to reproduce the behavior:

  1. Load attached save on build 9908 or later
  2. Save.
  3. Load.

Expected behavior

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 0.D-9422-g8d5b04e [64-bit]
  • Graphics Version: Tiles
  • Mods loaded: [
    Dark Days Ahead [dda],
    Classes and Scenarios Mod [more_classes_scenarios],
    Stats Through Skills [StatsThroughSkills],
    Stats Through Kills [stats_through_kills],
    No Fungal Monsters [No_Fungi],
    Makeshift Items Mod [makeshift],
    Medieval and Historic Classes and Shields [Medieval_Stuff],
    More Survival Tools [More_Survival_Tools],
    Alternative Map Key [alt_map_key],
    Vehicle Additions Pack [blazemod]
    ]

Additional context

save

@ZhilkinSerg
Copy link
Contributor

Probably caused by #35538

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist <Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world labels Nov 18, 2019
@RDru
Copy link
Contributor Author

RDru commented Nov 18, 2019

Probably caused by #35538

From what I see this is in build 9909 and I have encountered this bug on 9908 already.

@AMurkin
Copy link
Contributor

AMurkin commented Nov 18, 2019

There is no build 9909. And #35538 is in the build 9908.

@ZhilkinSerg
Copy link
Contributor

Probably caused by #35538

From what I see this is in build 9909 and I have encountered this bug on 9908 already.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Character / World Generation Issues and enhancements concerning stages of creating a character or a world (P2 - High) High priority (for ex. important bugfixes) (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants