Support item_locations on NPCs #35538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes serialization of ACT_READ for NPCs Add a new `character_id` field to `item_on_person` for serialization Lazily turn the character_id into a Character pointer on first access Also add a sainity check in the finish function of ACT_READ to prevent a crash if something goes wrong
ifreund
added
NPC / Factions
|
Made things a little more safe to avoid crashes and hopefully appease clang tidy. It doesn't feel super clean, so any suggestions on how to make the code nicer are welcome. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Support item_locations on NPCs"
Purpose of change
Fixes #35352
This commit fixes serialization of ACT_READ for NPCs
Describe the solution
Add a new
character_idfield toitem_on_personfor serializationLazily turn the character_id into a Character pointer on first access
Also add a sanity check in the finish function of ACT_READ to prevent
a crash if something goes wrong
Describe alternatives you've considered
Lazy loading of the Character pointers seemed like the way to go here, though if it turns out there's a way to guarantee all Characters are loaded before the item_locations, that would be preferable
Testing
Tested serialization/deserialization of NPCs while reading, no more crashes or debug messages!