Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few exploits allowing safe consumption of mutant meat #35573

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

Davi-DeGanne
Copy link
Contributor

Summary

SUMMARY: Balance "Fix a few exploits allowing safe consumption of mutant meat"

Purpose of change

These exploits were present:

  • Any item that copied from cooked meat (i.e. dehydrated meat) would lose all downsides of mutant meat upon crafting it into anything else, due to inheriting the "cooks_like": "meat_cooked" property.
  • Items that copied from cooked meat but didn't override its flags (i.e. vacuum-packed meat), also inherited NUTRIENT_OVERRIDE, meaning they didn't inherit downsides from mutant meat when crafted.

Describe the solution

  • Cooked meat now inherits from abstract item flesh instead of raw meat, so that it doesn't have erroneous "cooks_like": "meat_cooked" (the item should be unchanged otherwise).
  • Vacuum-packed meat, pickled meat, and rehydrated meat all had NUTRIENT_OVERRIDE removed.

Describe alternatives you've considered

Testing

Additional context

Cooked meat had

"copy-from": "meat"

which meant that it had by extension

"cooks-like": "meat_cooked"

which was causing weird behavior, like an exploit where mutant meat did
not have negative effects if dehydrated before cooking.
Several methods of meat preservation were removing toxins from food.
This was because those foods were inheriting NUTRIENT_OVERRIDE, which
was unnecessary thanks to the cooks-like property.
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks labels Nov 18, 2019
@ZhilkinSerg ZhilkinSerg merged commit f69236d into CleverRaven:master Nov 18, 2019
@Davi-DeGanne Davi-DeGanne deleted the dehydrated-meat-fix branch November 23, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants