Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutant Organs cook incorrectly #52166

Closed
anoobindisguise opened this issue Oct 7, 2021 · 4 comments · Fixed by #58007
Closed

Mutant Organs cook incorrectly #52166

anoobindisguise opened this issue Oct 7, 2021 · 4 comments · Fixed by #58007
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@anoobindisguise
Copy link
Contributor

Describe the bug

Mutant Organs (from bugs) cook like regular meat, inheriting the calories and vitamins (and lack of toxins) of regular meat but still having the "gross mutant meat" -5 morale tag. Though it cannot be cooked on its own like other organs, which itself is also an issue, its strange properties can be observed by making canned or pickled offal. (On an unrelated note there is no 3L variant of pickled offal unlike most other canning and pickling options). Upon being crafted into canned or pickled "offal", the resulting item has the same calories and vitamins of cooked meat (except for being "unappetizing mutant meat") and says it is made of cooked meat, although it occasionally produces results with half the calories. This is likely because it copies from Offal, an obsolete food that copies from regular meat, but I don't know exactly how the cooking system works under the hood.

Steps To Reproduce

  1. Attempt to cook Mutant Organs. Canned, Pickled, Sausage, any works.
  2. Observe through the powers of alchemy/Blob Magic the organs are transmuted into mysterious gross but nontoxic ordinary animal meat.

Expected behavior

Mutant Organs should have their own "cooked" version, and properly translate into various prepared versions.

Screenshots

offal1

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: bfe9028 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions],
    Graphical Overmap [Graphical_Overmap],
    Blaze Industries [blazeindustries]
    ]

Additional context

No response

@Maleclypse Maleclypse added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 10, 2021
@kwl01skz
Copy link
Contributor

kwl01skz commented Oct 23, 2021

Long ago, all internal organs were offal, and cooked offal also existed. Later, offal was divided into lung, liver, etc. it seems that offal will not be produced in the game, so the recipe of cooked offal was deleted (but raw offal and cooked offal are still retained).

I will add a 3L glass jar to the pickled offal recipe and add a recipe for cooking bug organs.

But I can't modify their nutrients. This mistake looks like #52287 .

Owlblocks added a commit to Owlblocks/Cataclysm-DDA that referenced this issue Nov 18, 2021
@Owlblocks
Copy link
Contributor

I just wrote a commit fixing mutant bug organs so they no longer have parasites after being cooked (I decided to write this in here, rather than starting a separate issue, because it's related to @kwl01skz 's fix. :)

@hexagonrecursion
Copy link
Contributor

hexagonrecursion commented Jan 4, 2022

Confirmed. I have butchered a giant ant (id: mon_ant) and got the "mutant organs" item. I then used it to cook "cooked mutant bug organs". The result did not report as toxic.

DeepinScreenshot_select-area_20220104131406
DeepinScreenshot_select-area_20220104131612

  • OS: Linux
    • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 34 (Thirty Four); Release: 34; Codename: ThirtyFour;
  • Game Version: eacb7d9 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

@wapcaplet wapcaplet added (S2 - Confirmed) Bug that's been confirmed to exist Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bug> This needs to be fixed and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jan 17, 2022
@snipercup
Copy link
Contributor

Same issue as in #35573. It enherits the NUTRIENT_OVERRIDE flags. The fix should be the same, so adding the
"delete": { "flags": [ "NUTRIENT_OVERRIDE" ] },
property to the cooked mutant bug organs should fix it. Although I wonder if it should copy-from mutant_bug_organs->offal->meat in the first place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants