Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooking mutant organs retain toxins #58007

Merged

Conversation

snipercup
Copy link
Contributor

Summary

Bugfixes "Cooking mutant organs will now retain their toxins"

Purpose of change

Fixes #52166

Describe the solution

Copies what the mutant meat scrap and the cooked mutant meat scrap does. This means adding the 'cooks-like' property to the mutant organs and setting that property to cooked mutant organs. This is required because otherwise it will inherit the cooks-like from meat. You can see this in #52166, where the description says it's made from cooked meat, not mutant organs.

The consequence is that the calories differ from before, since mutant organs are not the same as 'cooked meat'

Describe alternatives you've considered

Re-doing the inheritance of the meat dishes since figuring this out took more time then I'd like. Right now anything that inherits from meat will cook-like cooked meat, and override their nutrients. Also, the cooked mutant organs ended up with both cooks-like and the NUTRIENTS_OVERRIDE flag while #27252 says they are alternatives.

Testing

Loaded the game, butchered ants, crafted cooked offal, cooked mutant organs, canned offal

Additional context

Offal inherits toxins:
image

Picked offal too:
image

cooked mutant organs too:
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 29, 2022
@dseguin dseguin merged commit fffbe01 into CleverRaven:master May 30, 2022
@snipercup snipercup deleted the Cooking-mutant-organs-retains-toxins branch June 1, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutant Organs cook incorrectly
2 participants