Fix "Mini-Flamethrower CBM lights fuelless fires" #35271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO it should remain as flamethrower. With some fuel consumption like gasoline or even napalm. |
|
But it never actually worked as a flamethrower, it was just able to light fuelless fire on the pavement on a tile next to you |
curstwist
added
<Bugfix>
|
It seems like 75 kJ is now way overpriced for what the CBM does. This should probably use less energy than the electric firestarter, since that one is "inefficient". The firestarter is |
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Nov 5, 2019
* bio_lighter can't light pavement on fire * Rename to Finger Lighter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Mini Flamethrower CBM is really just a lighter"Purpose of change
Fixes #28855
Describe the solution
Check if terrain is flammable before lighting the fire
If not don't light fire
Rename
Mini-FlamethrowertoFinger Lightersince that's what it is.Describe alternatives you've considered
Testing
Activate bio_lighter on pavement
No Fire
Activate bbio_lighter on a bush
Fire
Activate a lighter on another bush
Wait
Both fire go out about at the same time
Additional context
If someone has a better name than Finger Lighter I can change it again.
bio_lighter light instant fire at the cost of 100 move, it does not use the start_fire activity. I don't know if it's intended or not.