Bring bio_lighter in line with crude_firestarter #35373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crude_firestarter uses 5 energy, which seems to translate to 5 kJ. Since that's crude and inefficient, I made the CBM firestarter use 3 kJ.
curstwist
added
Bionics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Bring bio_lighter energy in line with crude_firestarter"Purpose of change
crude_firestarter uses 5 energy, which seems to translate to 5 kJ. The bionic lighter costs 75 kJ, owing to its recent status as a mini-flame thrower. Since it's just a lighter as of #35271, the price should be corrected.
Describe the solution
Since crude_firestarter is crude and inefficient, I made the CBM firestarter use 60% as much energy as the former.
Describe alternatives you've considered
Restoring the CBM into a flamethrower, but make the resulting flames only burn for 2 or 3 seconds without additional fuel. If folks prefer the flamethrower version over the more realistic lighter, I could try that instead.
Testing
Started some fires using this and saw that 3 jK was indeed subtracted.
Additional context
#35271 correctly identified that the bio_lighter was producing ridiculously long-lived flames.