Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini-Flamethrower CBM lights fuelless fires #28855

Closed
Photoloss opened this issue Mar 20, 2019 · 7 comments · Fixed by #35271
Closed

Mini-Flamethrower CBM lights fuelless fires #28855

Photoloss opened this issue Mar 20, 2019 · 7 comments · Fixed by #35271
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed

Comments

@Photoloss
Copy link
Contributor

Describe the bug
Unlike most lighters the mini-flamethrower can be used on empty tiles to light a fully-fledged fire. It can burn for several minutes and deal fatal damage to creatures. Nothing in the usage cost provides any combustible fuel to sustain such a blaze, nor is there any easy explanation to add one to a finger implant.

To Reproduce
Steps to reproduce the behavior:

  1. Install Mini-Flamethrower CBM
  2. Use it on an empty, non-flammable tile such as a road
  3. Wait for several minutes by holding the "pass turn" button, optionally kite a monster into the flames.

Expected behavior
A purely electrical heater could potentially dry out and ignite certain living plants where a match might fail, but ultimately there needs to be enough fuel to actually maintain combustion. Harvesting metabolic waste, blood sugar or body fat might be a valid explanation but this would incur a cooldown on repeated uses and/or a metabolic cost on each activation (similar to active mutations).

Otherwise, and more suited to the implied technological context, the CBM should be unusable on empty tiles just like other lighters. Its current usage time and energy cost implies a power consumption of 1500W which is on the low end for modern toasters, kettles or hairdryers and thus barely enough to cause combat-relevant injuries on direct application. At this point it ought to be renamed as well since anything vaguely resembling a flamethrower definitely needs a stream of fuel projected at the target.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Bionics CBM (Compact Bionic Modules) labels Mar 21, 2019
@Xpyder
Copy link
Contributor

Xpyder commented Mar 22, 2019

maybe it could launch a quick, short lived, burst of fire that can ignite combustibles on tiles it hits?

@Photoloss
Copy link
Contributor Author

Define "fire". The common understanding involves both air/oxygen and a combustible fuel, where does this fuel come from? Pre-heating air/steam to ignition temperatures to release a short burst is neither safe nor effective compared to a continuous resistive heating+fan setup.

@Xpyder
Copy link
Contributor

Xpyder commented Mar 23, 2019

where does this fuel come from?

A short lived flame (1 roundish) can be fueled by suspension of disbelief. The main purpose would be to light any combustible materials in the affected cells

Clarification: Given the name I'm operating under the assumption this is intended as a combat utility bionic. If it's purely for survival (replacing lighters) then I would instead suggest it be renamed.

@kevingranade
Copy link
Member

Why would you start a nonsense fire instead of just igniting the fuels in question?
If implementation wise you want to make an ephemeral fire, it should only last until the end of the next field processing tick, i.e. it should disappear before the player has a chance to see it.

@Xpyder
Copy link
Contributor

Xpyder commented Mar 23, 2019

So the player understands what happened, that it worked correctly, why it went out, and what the range is, without having to meticulously lay out clothing to test it's invisible effect.

@Xpyder
Copy link
Contributor

Xpyder commented Mar 27, 2019

Also, to clarify
• I'm operating under the assumption that it creates a 3x3 area of flame like other small flamethrowers, if its a 1x1 area specifically then that conveyance happens using the targeting (I wonder if targeting could show a ghost or expanded box for aoe effects? hmm.. but that would be beyond the scope of this issue)
• It doesn't have to be a real fire. Just something that looks like it (or close enough™) to the player. How the ignition is actually coded is a different matter entirely, and I know there's some weirdness where fuel-less fires still manage to burn for too long so I agree it ideally wouldn't spawn a "real" fire, just something that looks like it for a sec so the player doesn't think it misfired and failed to mention it in the log.

@Photoloss
Copy link
Contributor Author

@Xpyder nope, 1 tile of fire adjacent to you, basically as if you were using a lighter except it also works on non-flammable terrain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) <Bug> This needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants