Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire burns without fuel #29060

Closed
Xpyder opened this issue Mar 27, 2019 · 2 comments · Fixed by #29115
Closed

Fire burns without fuel #29060

Xpyder opened this issue Mar 27, 2019 · 2 comments · Fixed by #29115
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features.

Comments

@Xpyder
Copy link
Contributor

Xpyder commented Mar 27, 2019

Describe the bug
Fire continues to burn for several minutes in the absence of fuel

To Reproduce
wish for
• brazier
• a stack of two by fours
• a lighter
then toss a two by four in the brazier and light it
then pull it out of the brazier
notice that
• burnt two by four doesn't spread fire
• fire continues burning for a LONG time

Expected behavior
Either fire follows the two by four, or extinguishes

Screenshots
ask if need

Versions and configuration(please complete the following information):

  • OS: ask if need
  • Game Version: ask if need
  • Graphics version: ask if need
  • Mods loaded: ask if need

Additional context
• It's likely the fire is consuming part of the wood and then continuing to burn, presumably for efficiency, with large fires constantly checking for fuel could become taxing for the system. Maybe it should check more often for small fires (eating in smaller chunks), and less often for roaring fires or infernos (eating in bigger chunks) for scaling if this is indeed a problem?
• Likely root cause of the balance issue in #28855

@nexusmrsep
Copy link
Contributor

Fire has internal fuel count and unfortunately it's code is quite old and tangled, so there are also two methods of burning. One burns items gradually adding small amounts of fuel. Second burns items quickly adding lots of invisible fuel. Second one can create illusion of fuelless fire. Methods differ between contained fires (braziers etc.) and wild free fires.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Mar 28, 2019
@ghost
Copy link

ghost commented Mar 29, 2019

#29046 possibly caused by #28058 if the behaviour is different to previous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Fields / Furniture / Terrain / Traps Objects that are part of the map or its features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants