Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cough #35263

Merged
merged 97 commits into from
Nov 5, 2019
Merged

Migrate cough #35263

merged 97 commits into from
Nov 5, 2019

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Nov 2, 2019

Summary

SUMMARY: Infrastructure "Migrates cough from player to character"

Purpose of change

Part of #34721 Migrates cough from player to character
Adds debug feature to give character the flu

Describe the solution

I moved the code from player to character

Describe alternatives you've considered

Testing

Additional context

Ramza13 and others added 30 commits October 10, 2019 07:35
Co-Authored-By: anothersimulacrum <[email protected]>
This reverts commit 88637aa.
… of item on arm break if it can't be wielded anymore
This reverts commit 98e88b3.
…d decided to still allow martial arts/normal attack damage while on the ground
Fix some more typos and delete some extra spaces
curstwist and others added 21 commits October 16, 2019 18:47
The helper function get_item_location() did not support items being in
vehicles.  This commit corrects that oversight.
* finish reorganizing furniture.json

* remove duplicats, add coat rack
…ter to Character (CleverRaven#34761)

* change scope of crossed_threshold()

* moved crossed_threshold to character.cpp

* change parameter of test_crossing_threshold to Character

* change "p" to "guy"
* Migrate move mode and related code from player

 - Hoist the move_mode variable up to character since NPCs should crouch
   and run someday
 - Drop UI-related code down to avatar
 - Serialize/deserialize move_mode in the character functions
 - Tweak related code to accomadate the changes

* Migrate get_overlay_ids() to Character

This fixes compilation of SDL builds
…rol unit (CleverRaven#34202)

* Added turret control unit

* Made it craftable (autolearn)

* Added corresponding vehicle part

* Added flag to bitflags set

* Added documentation

* Forcibly set turrets' targeting mode to manual if no turret control unit is present on turret's tile on loading save

* Allow changing turrets' targeting mode only if turret control unit is present

Also reworded targeting mode options a bit to reduce confusing.
Also removed a check for MANUAL flag as there is no items or vehicle parts with this flag.
Also reworded reason of why you can't aim automatic turrets and added a missing period.

* Turret controls must be installed on a turret

Also, on removing turret controls forcibly set targeting mode of affected turret to manual.

* Set turret control unit's state equal to turret's targeting mode

* Increased control unit power draw

* Added a requirement for laptop computer

Also inreased craft time to 2 hours.

* Added mechanics skill req for crafting TCU

Also increased its power consumption from 100W to 250W.
Condense melee weapons into one file
…en#34653)

* Triples the number of wands

Introduces Channel Wands and Disposable Wands.

* removed channel wands

* Update enchanted_wands.json
Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make changes and move things in the same PR.

src/character.cpp Outdated Show resolved Hide resolved
@Ramza13
Copy link
Contributor Author

Ramza13 commented Nov 2, 2019

Please don't make changes and move things in the same PR.

Sorry about that. Separating them now

@Ramza13 Ramza13 changed the title Migrate/rebalance cough Migrate cough Nov 2, 2019
@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Nov 4, 2019
@kevingranade kevingranade merged commit 0a0ab70 into CleverRaven:master Nov 5, 2019
@Ramza13 Ramza13 deleted the nerf_cough branch November 17, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.