Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unarmed experience scaling with only bash damage #34723

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

Xanderga
Copy link
Contributor

@Xanderga Xanderga commented Oct 13, 2019

Summary

SUMMARY: Bugfixes "Fix unarmed experience gain calculation"

Purpose of change

Unarmed experience was previously calculated with purely bash damage. However, the vast majority of unarmed weapons do not deal purely bash damage, which is the value used for practice for experience calculations. Only two weapons exist that are purely unarmed bash, Cestus and Pair of Steel Knuckles. Unarmed also trained cutting and piercing, but not bashing.

Describe the solution

Change Unarmed so that all damage dealt while unarmed (pierce, bash, and cut) contribute solely to unarmed exp.

Testing

Only have the following enabled for experience gain at level 0:
Piercing
Cutting
Bashing
After killing a zombie while unarmed, experience for the above skills were 0%.
After killing a zombie while armed with a pair of nail knuckles, the above skills were 0%.
After killing a zombie while armed with a cudgel, bashing experience increased.

Only have unarmed enabled:
After killing a zombie while unarmed, unarmed experience increased.
After killing a zombie while armed with a pair of nail knuckles, unarmed experience increased.
After killing a zombie while armed with a cudgel, no experience gained..

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Melee Melee weapons, tactics, techniques, reach attack labels Oct 14, 2019
@ZhilkinSerg ZhilkinSerg merged commit 43dbce7 into CleverRaven:master Oct 16, 2019
Ramza13 pushed a commit to Ramza13/Cataclysm-DDA that referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants