Fixed unarmed experience scaling with only bash damage #34723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix unarmed experience gain calculation"
Purpose of change
Unarmed experience was previously calculated with purely bash damage. However, the vast majority of unarmed weapons do not deal purely bash damage, which is the value used for practice for experience calculations. Only two weapons exist that are purely unarmed bash, Cestus and Pair of Steel Knuckles. Unarmed also trained cutting and piercing, but not bashing.
Describe the solution
Change Unarmed so that all damage dealt while unarmed (pierce, bash, and cut) contribute solely to unarmed exp.
Testing
Only have the following enabled for experience gain at level 0:
Piercing
Cutting
Bashing
After killing a zombie while unarmed, experience for the above skills were 0%.
After killing a zombie while armed with a pair of nail knuckles, the above skills were 0%.
After killing a zombie while armed with a cudgel, bashing experience increased.
Only have unarmed enabled:
After killing a zombie while unarmed, unarmed experience increased.
After killing a zombie while armed with a pair of nail knuckles, unarmed experience increased.
After killing a zombie while armed with a cudgel, no experience gained..