basecamps: fix NPCs disappearing when crafting in expansions #34078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPCs would disappear into the ether when crafting in an expansion if the basecamp had a copy of the same recipe. The basecamp craft function would dispatch the NPC, but with the wrong companion mission information, making it impossible to recall them. Make the basecamp craft mission start check for the basecamp direction before running. Notes: this will conflict with Qrox's basecamp refactor from CleverRaven#34058 but the conflict resolution should be obvious.
mlangsdorf
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "basecamps: fix NPCs disappearing when crafting in expansions"Purpose of change
Fixes #30850
NPCs would disappear into the ether when crafting in an expansion if the basecamp had a copy of the same recipe. The basecamp craft function would dispatch the NPC, but with the wrong companion mission information, making it impossible to recall them.
Describe the solution
Gate the basecamp
start_crafting()call behind a check to see if miss_dir is the base_dir for the camp.Additional context
Tested by having two NPCs craft tinder at the same time, one at the basecamp and one at the kitchen expansion, and being able to recall them both and send them back out to craft more tinder repeatedly.