Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fields (step 8) #32491

Merged
merged 5 commits into from
Jul 27, 2019

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Jul 19, 2019

Summary

SUMMARY: Infrastructure "Refactor fields (step 8)"

Purpose of change

Unhardcode data structures to allow field type customization/addition via json.

Describe the solution

Current pull request does the following:

  • unhardcodes several field type attributes (gas spreading, npc complaints, extra radiation and wandering fields from vents).

Additional context:

Includes changes from #32481 and #32488.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Jul 19, 2019
@kevingranade kevingranade merged commit 843eb2a into CleverRaven:master Jul 27, 2019
@ZhilkinSerg ZhilkinSerg deleted the refactor-fields-step-8 branch July 27, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants