Refactor fields (step 7) #32488

ZhilkinSerg · 2019-07-19T01:05:19Z

Summary

SUMMARY: Infrastructure "Refactor fields (step 7)"

Purpose of change

Unhardcode data structures to allow field type customization/addition via json.

Describe the solution

Current pull request does the following:

code refactoring for field immunity (and some minor refactoring elsewhere);
unhardcodes several field type attributes (convection temperature modifier, gas absorption factor and field splattering).

Additional context:

Includes changes from #32481.

src/iuse_actor.cpp

src/vehicle_use.cpp

src/mondeath.cpp

src/mapgen.cpp

src/map.cpp

Co-Authored-By: Isaac Freund <[email protected]>

ZhilkinSerg added 13 commits July 19, 2019 00:18

Fixed typos in field intensity level names

08940e5

Unhardcoded field decay amount factor

b023e84

Unhardcoded field apply slime factor

fb7b5b0

Unhardcoded transparency cache invalidation by fields

6390100

Unhardcoded light emitted by fields

6ca9bc8

Unhardcoded field highlight on character

8c23002

Unhardcoded field translucency

83e74e3

Unhardcoded convection temperature modifier

dd976c2

Unhardcoded gas absorption factor

677b98d

Refactored field immunity code

0c43641

Null field check through function

2b27594

Do not use field type id in acid/fire check

2cc4351

Unhardcoded field splattering

de0bef9

ZhilkinSerg added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Jul 19, 2019

ZhilkinSerg mentioned this pull request Jul 19, 2019

Refactor fields (step 8) #32491

Merged

ifreund reviewed Jul 22, 2019

View reviewed changes

src/iuse_actor.cpp Outdated Show resolved Hide resolved