Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic phase 7 - spell effects #30428

Merged
merged 1 commit into from
May 24, 2019

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Infrastructure "Adds magic spell effects"

Purpose of change

Spell effects are how a spell decides exactly what it does. It's defined in json as a simple string, and then determins which function to call during the spellcasting action (next PR)
This is the 7th PR in the magic mod series -- #30425 is the prerequisite.

Describe the solution

Describe alternatives you've considered

Additional context

@KorGgenT KorGgenT added Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` labels May 11, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this May 12, 2019
@KorGgenT KorGgenT force-pushed the magic-7-spell-effects branch from 91be277 to a217364 Compare May 15, 2019 03:35
@ZhilkinSerg ZhilkinSerg removed their assignment May 15, 2019
@KorGgenT KorGgenT force-pushed the magic-7-spell-effects branch 4 times, most recently from 9a4632b to c9a911e Compare May 23, 2019 20:18
@KorGgenT KorGgenT force-pushed the magic-7-spell-effects branch from c9a911e to 8b33f5f Compare May 24, 2019 10:26
@ZhilkinSerg ZhilkinSerg self-assigned this May 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit 2660bc3 into CleverRaven:master May 24, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment May 24, 2019
@KorGgenT KorGgenT deleted the magic-7-spell-effects branch May 28, 2019 21:52
@KorGgenT KorGgenT added the Mods: Magiclysm Anything to do with the Magiclysm mod label Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants