Magic phase 6 - spell learning (through spellbooks) #30425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
KorGgenT
force-pushed
the
magic-6-spell-learning
branch
from
c77b733 to
41582ae
Compare
AMurkin
reviewed
May 11, 2019
src/ranged.cpp
Outdated
| if( casting.aoe() > 0 ) { | ||
| nc_color color = c_light_gray; | ||
| if( casting.effect() == "projectile_attack" || casting.effect() == "target_attack" ) { | ||
| line_number += fold_and_print( w_target, line_number, 1, getmaxx( w_target ) - 2, color, |
|
I apologise for being horribly pedantic, but I dunno where to put this. What exactly will the magic mod be like for the average player? |
|
well, if you would like to see a demo of my currently working magic mod, Here is a link to the (pre)release |
|
I'm on my craptop, but I'll try to remind myself to look at it. I like the work you're doing here. |
KorGgenT
force-pushed
the
magic-6-spell-learning
branch
from
bea9816 to
fc064a1
Compare
KorGgenT
force-pushed
the
magic-6-spell-learning
branch
8 times, most recently
from
2763437 to
7eb2bf8
Compare
|
jenkins rebuild |
KorGgenT
force-pushed
the
magic-6-spell-learning
branch
from
7eb2bf8 to
e5c3336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Adds the learn_spell iuse action"Purpose of change
This is one of the four (planned) ways to gain spells, and by far the most common (at least in the mod i will be maintaining)
An iuse action called "learn_spell" will ble added to items, so you can learn or study the spell by spending time, much like reading. The time spent learning the spell and the rate at which you gain exp are highly dependent upon the various magic spells.
This is the 6th PR in the magic series of PRs - #30422 is the prerequisite to this one.