Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading a map tanks overmap view performance #70540

Closed
TheAnay256 opened this issue Dec 31, 2023 · 0 comments · Fixed by #70574
Closed

Reading a map tanks overmap view performance #70540

TheAnay256 opened this issue Dec 31, 2023 · 0 comments · Fixed by #70574
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Map / Mapgen Overmap, Mapgen, Map extras, Map display

Comments

@TheAnay256
Copy link

Describe the bug

After using a map, overmap view performance is noticeably slowed. This compounds with each additional map read, until the overmap view is essentially unusable. Almost certainly related to this PR: #70482

A workaround is to "Save & Exit" and then relaunch the game.

Attach save file

N/A - Trivial to reproduce

Steps to reproduce

To reproduce:

  1. Enter game
  2. Spawn any map item
  3. Use map item
  4. Open overmap with M

Expected behavior

I expect that the overmap view will continue to function normally after reading a map item.

Screenshots

No response

Versions and configuration

Windows 10 using launcher
Tiles

Additional context

No response
@TheAnay256 TheAnay256 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 31, 2023
@BrettDong BrettDong added Code: Performance Performance boosting code (CPU, memory, etc.) Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Dec 31, 2023
@Maleclypse Maleclypse mentioned this issue Jan 1, 2024
Closed
db48x added a commit to db48x/Cataclysm-DDA that referenced this issue Jan 1, 2024
@db48x
fix performance of the map view after reading a map
0e7ff3d 
When you read a map, we now keep track of what overmap tiles the map
revealed to you, so that we can blink them in the map view. I’ve
changed it from a vector of coordinates to an unordered_set, so that
membership testing is O(1), greatly improving performance.

fixes CleverRaven#70540
@db48x db48x mentioned this issue Jan 1, 2024
Merged
@NetSysFire NetSysFire removed the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code: Performance Performance boosting code (CPU, memory, etc.) Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix performance of the map view after reading a map db48x/Cataclysm-DDA
3 participants
@TheAnay256 @BrettDong @NetSysFire