Escalating Game Performance Woes: From Laggy Moves to Complete Freezes

[Radonchnk]

Describe the bug

Recently, the game's performance has noticeably declined, with occasional delays of a few seconds for moves to process. However, the current situation is more severe, as the game freezes for 30 seconds or more after each input.

Attach save file

Peach Lake-trimmed.tar.gz

Steps to reproduce

Press any move button

Expected behavior

The game is expected to operate seamlessly, yet it consistently experiences freezing issues.

Screenshots

No response

Versions and configuration

os - Linux Mint 21.1 x86_6
Kernel: 5.15.0-89-generic
Shell: bash 5.1.16
DE: Xfce 4.16
WM: Xfwm4
CPU: 11th Gen Intel i3-1115G4 (4) @
GPU: Intel Device 9a78
Memory: 4665MiB / 15734MiB

version - f94a31e
tileset, mods - standard

Additional context

No response

[Maleclypse]

Had you recently read several maps?

[Radonchnk]

Sorry, but i do not understand the question

[Maleclypse]

#70540 is this your problem? Or if you spawn a clairvoyance artifact are you over a slime pit?

[akrieger]

NPC crafting is going haywire somehow. This was over a minute of tracing for a single step that I didn't even let complete.

[akrieger]

Spending all its time creating a crafting inventory? Twice?

[akrieger]

#70423 would help with this some because it just makes item stuff 'faster' but it doesn't fix the underlying algorithmic issue. I can't tell if there's a bug here causing a potentially infinite loop or just an inefficient process your save is exposing.

[akrieger]

Maybe there's a large backlog that's not doing backoff correctly.

[harakka]

/confirm

[akrieger]

What seems to be happening is an NPC is trying to do a multi craft but has a computed crafting speed of zero. This causes it to burn all of its moves (nearly 1000) one at a time trying and failing to do a craft, which is very, very expensive.

[akrieger]

The crafting speed is reduced to zero by a manipulation limb score modifier which ends up with a negative modifier which zeroes everything out.

[akrieger]

Then even though it is cancelled, it gets pushed into the backlog and automatically retried.

[akrieger]

This seems to fix the issue by not having the npc loop and fail constantly at crafting.

Cataclysm-DDA/src/activity_actor.cpp

Lines 3385 to 3388 in a1b4bad

	if( crafting_speed <= 0.0f ) {
	crafter.cancel_activity();
	return;
	}

diff --git a/src/activity_actor.cpp b/src/activity_actor.cpp
--- a/src/activity_actor.cpp
+++ b/src/activity_actor.cpp
@@ -3380,6 +3380,7 @@
     const int assistants = crafter.available_assistant_count( craft.get_making() );

     if( crafting_speed <= 0.0f ) {
+        crafter.set_moves( 0 );
         crafter.cancel_activity();
         return;
     }

but I don't know how to validate it for side effects.