fix performance of the map view after reading a map #70574
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you read a map, we now keep track of what overmap tiles the map revealed to you, so that we can blink them in the map view. I’ve changed it from a vector of coordinates to an unordered_set, so that membership testing is O(1), greatly improving performance. fixes CleverRaven#70540
github-actions
bot
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performance "fix performance of map view after reading a map"
Purpose of change
When you read a map, we now keep track of what overmap tiles the map revealed to you, so that we can blink them in the map view. Unfortunately the initial implementation of this feature turned out to be rather slow.
Describe the solution
I’ve changed it from a vector of coordinates to an unordered_set, so that membership testing is O(1), greatly improving performance.
fixes #70540