Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed adjustments from effects are listed twice in the UI #68633

Closed
John-Candlebury opened this issue Oct 13, 2023 · 3 comments
Closed

Speed adjustments from effects are listed twice in the UI #68633

John-Candlebury opened this issue Oct 13, 2023 · 3 comments
Labels
Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@John-Candlebury
Copy link
Member

Describe the bug

Despite the adjustments applying properly, any adjustment effect is displayed twice within the @ character screen causing posible confusion,

Attach save file

N/A

Steps to reproduce

  1. Spawn any character.
  2. Use the debug menu and grant you a simple speed adjusting effect (I suggest the monster staggered or frenzy effects since they are simple).
  3. Notice that both the sidebar and the speed total sum within the @ character sheet displays your correct speed, but the adjustment is listed as if it were aplying twice

Expected behavior

The UI only prints the speed adjustment once.

Screenshots

imagen

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.2283 (22H2)
  • Game Version: 0.G-4531-g11a2c1e605-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Aftershock [aftershock]
    ]

Additional context

No response

@John-Candlebury John-Candlebury added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 13, 2023
@GuardianDll
Copy link
Member

/confirmed, since #65037 exist

also #64612 (comment)

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 13, 2023
@Maleclypse Maleclypse added Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics labels Oct 22, 2023
@RenechCDDA RenechCDDA moved this to Proposed Release Blockers in 0.H Release Tracker Nov 24, 2023
@RenechCDDA RenechCDDA moved this from Proposed Release Blockers to Accepted Release Blockers in 0.H Release Tracker Dec 11, 2023
@alef
Copy link
Contributor

alef commented Jan 9, 2024

Adding one speed effect via debug and opening @ immediately, it will show only one.
But stepping the game forward, it duplicates it.

alef added a commit to alef/Cataclysm-DDA that referenced this issue Jan 10, 2024
Maleclypse pushed a commit that referenced this issue Jan 14, 2024
* #68633 Avoid duplicates in speed adjustments

* Obey astyle
@Maleclypse
Copy link
Member

Closed by #70831

@github-project-automation github-project-automation bot moved this from Accepted Release Blockers to Completed in 0.H Release Tracker Jan 28, 2024
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this issue May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Mechanics: Character / Player Character / Player mechanics (S2 - Confirmed) Bug that's been confirmed to exist
Projects
Status: Completed
Development

No branches or pull requests

4 participants