#68633 Avoid duplicates in speed adjustments #70831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Avoid duplicates in speed adjustments"
Purpose of change
Creature::effects
can be altered by the debug menu, butCharacter::mod_speed_bonus
is altered during a turn, so in the future. This is probably what created confusion, as by the note comment in previous code.Describe the solution
I inverted the two loops so that I first fill the
std::vector
with thestd::map
.Then I append
speed_bonus_effects
but using thestd::map
to avoid duplicates.Describe alternatives you've considered
Testing
Only on Windows 10 SDL, under VS debugger. Using Debug menu to add frenzy effect, step through code and observe.
Additional context