[cmake] FindCurses.cmake ignores CURSES_NEED_WIDE , can't compile with ncursesw

[rumly111]

Until now I didn't use the provided Makefile but generated it with cmake. Building TILES version worked just fine, but when I tried building CURSES version, I noticed it is linked with libncurses.so , instead of libncursesw.so

There is a placeholder variable in CMakeLists.txt (CURSES_NEED_WIDE), but later on it is ignored in CMakeModules/FindCurses.cmake

[Jookia]

I accidentally reproduced this in #39361 where it compiled fine but broke at runtime. This is because CMAKE_MODULE_PATH prefers the FindCurses shipped with the source code instead of the system-wide FindCurses which works fine. FindCurses should be updated to search for ncursesw now that the game depends on it.

[rumly111]

I accidentally reproduced this in #39361 where it compiled fine but broke at runtime. This is because CMAKE_MODULE_PATH prefers the FindCurses shipped with the source code instead of the system-wide FindCurses which works fine. FindCurses should be updated to search for ncursesw now that the game depends on it.

I looked into my /usr/share/cmake-3.5/Modules/FindCurses.cmake , but there is no ncursesw in it. So we can't depend on it.

[Jookia]

Maybe the latest CMake FindCurses should be copied to this tree. I'm unsure how to test it with older CMake versions or verify it works with CMake 3.1 which is what CMakeLists.txt specifies it though.

[rumly111]

Maybe the latest CMake FindCurses should be copied to this tree. I'm unsure how to test it with older CMake versions or verify it works with CMake 3.1 which is what CMakeLists.txt specifies it though.

Maybe try installing Ubuntu 14.04 in a virtual machine or docker? I use Ubuntu 16.04, and it comes with CMake 3.5 . I wonder if simply copying can be a solution.

BTW, it's possible to compile CDDA with cursesw, if you use the provided makefile (not cmake).

[Jookia]

Simply copying it and a dependency worked on my machine on Debian 10. I could do this as a WIP PR and if someone with a Ubuntu 14.04 container setup wants to test it. I don't have a setup that can do containers at the moment.

…

On Thu, Apr 09, 2020 at 01:11:54AM -0700, Joseph Botosh wrote: Maybe the latest CMake FindCurses should be copied to this tree. I'm unsure how to test it with older CMake versions or verify it works with CMake 3.1 which is what CMakeLists.txt specifies it though. Maybe try installing Ubuntu 14.04 in a virtual machine or docker? I use Ubuntu 16.04, and it comes with CMake 3.5 . I wonder if simply copying can be a solution. — You are receiving this because you commented. Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe. References 1. #39053 (comment) 2. https://github.com/notifications/unsubscribe-auth/AABNHOYDARJXXX4P2RR47Z3RLV7MVANCNFSM4LU2GMFQ

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[stale]

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

[anothersimulacrum]

This means that people can't use curses when building in certain ways, this should be fixed.

[kevingranade]

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/strange-text-troubles/24209/5