Gibberish around some text in curses build #39361
Comments
|
Please try compiling with LOCALIZE=1 and see if it will display Unicode characters properly. |
|
It looks like might be related to the terminal escapes used to change colour. What terminal are you running in? Do other things which use colour work fine? What about other curses apps? |
I am pretty sure it is because of the following in the Makefile: ifeq ($(LOCALIZE),1)
NCURSES_PREFIX = ncursesw
else
NCURSES_PREFIX = ncurses
endif |
|
I'm use xfce4-terminal which reports as xterm-256color. Pretty standard
stuff, and I expect escapes would begin with something like ^[[ for this
terminal, so I'm not sure if that's the case. I'll try under tmux and
screen when I recompile.
I'm currently compiling 0.D to check this isn't a regression (it takes a
while), but I'll definitely see what's up with ncursesw- I'm using CMake
to compile so there could be a problem there.
I really want to emphasise that I'm compiling with -fsigned-char in
CMake
…On Wed, Apr 08, 2020 at 12:24:58PM -0700, ZhilkinSerg wrote:
It looks like might be related to the terminal escapes used to
change colour. What terminal are you running in? Do other things
which use colour work fine? What about other curses apps?
I am pretty sure it is because of the following in the Makefile:
ifeq ($(LOCALIZE),1)
NCURSES_PREFIX = ncursesw
else
NCURSES_PREFIX = ncurses
endif
—
You are receiving this because you authored the thread.
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
References
1. #39361 (comment)
2. https://github.com/notifications/unsubscribe-auth/AABNHOYKOXY2Y72VJ6E4NK3RLTFQVANCNFSM4MD2QATA
|
|
We had someone yesterday who had this problem when compiling with CMake, but not with Make on the discord. |
|
I haven't gotten CMake to link with ncursesw. This may be linked to
#39053
…On Wed, Apr 08, 2020 at 02:58:15PM -0700, anothersimulacrum wrote:
We had someone yesterday who had this problem when compiling with
CMake, but not with Make on the discord.
—
You are receiving this because you authored the thread.
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
References
1. #39361 (comment)
2. https://github.com/notifications/unsubscribe-auth/AABNHO65OREMO3CBXGTFW2LRLTXPPANCNFSM4MD2QATA
|
|
I worked around it and can confirm that's the bug. Closing and moving discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On master in the curses build some text is appended or prepended with junk like '-BM-(', '-b
TP', '~b-T-~T', 'M-BM-'. Line wraps seem to include garbage too include ampersands. These additional characters cause text to overflow to the next line in some windows in the game like the inventory.Steps To Reproduce
Start the game and go to the 'new game' menu. It should have some garbage if your terminal is narrow enough for it to line wrap. Otherwise enter the game itself and look at the UI.
Expected behavior
I expect the text to look something like the graphics version where there isn't this extra text that looks like escape codes.
Screenshots
Versions and configuration
20:40:19.038 : Starting log.
20:40:19.039 INFO : Cataclysm DDA version 0.D-13905-g7afe3c1b8a
20:40:21.908 WARNING : opendir [/home/jookia/.cataclysm-dda/mods/] failed with "No such file or directory".
20:41:04.558 WARNING : opendir [/home/jookia/.cataclysm-dda/save/Lenexa/mods] failed with "No such file or directory".
20:42:12.707 : GAME REPORT:
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
C.R.I.T Expansion Mod [crt_expansion],
DinoMod [DinoMod],
Graphical Overmap [Graphical_Overmap],
Stats Through Skills [StatsThroughSkills]
]
20:42:24.411 : Log shutdown.
Additional context
Compiler is arm-linux-gnueabihf-gcc-8, extra build flags are -fsigned-char
Describe the bug
On master in the curses build some text is appended or prepended with junk like '-BM-(', '-b
TP', '~b-T-~T', 'M-BM-'. Line wraps seem to include garbage too include ampersands. These additional characters cause text to overflow to the next line in some windows in the game like the inventory.Steps To Reproduce
Start the game and go to the 'new game' menu. It should have some garbage if your terminal is narrow enough for it to line wrap. Otherwise enter the game itself and look at the UI.
Expected behavior
I expect the text to look something like the graphics version where there isn't this extra text that looks like escape codes.
Screenshots
Versions and configuration
20:40:19.038 : Starting log.
20:40:19.039 INFO : Cataclysm DDA version 0.D-13905-g7afe3c1b8a
20:40:21.908 WARNING : opendir [/home/jookia/.cataclysm-dda/mods/] failed with "No such file or directory".
20:41:04.558 WARNING : opendir [/home/jookia/.cataclysm-dda/save/Lenexa/mods] failed with "No such file or directory".
20:42:12.707 : GAME REPORT:
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
C.R.I.T Expansion Mod [crt_expansion],
DinoMod [DinoMod],
Graphical Overmap [Graphical_Overmap],
Stats Through Skills [StatsThroughSkills]
]
20:42:24.411 : Log shutdown.
Additional context
Compiler is arm-linux-gnueabihf-gcc-8, built with '-fsigned-char' to avoid the build breaking.
The text was updated successfully, but these errors were encountered: