Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Link to libncursesw in CMake"
Purpose of change
Recently added widget test (#54050) uses
mvwinnwstr()
library function that is only available inlibncursesw
(wide version). However, current CMake build script links tolibncurses
(non-wide version) and causes build error on LGTM.com:Describe the solution
CMake added
ncursesw
detection support in CMake 3.10: Kitware/CMake@4b02afc .Pull the new
FindCurses.cmake
withlibncursesw
support from upstream CMake repository.Describe alternatives you've considered
Testing
Compile with CMake:
And verify the compiled executable depends on wide version of
libncursesw
:Additional context