Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Settings Not Saving #35631

Closed
Shinino opened this issue Nov 20, 2019 · 3 comments · Fixed by #35694
Closed

Terminal Settings Not Saving #35631

Shinino opened this issue Nov 20, 2019 · 3 comments · Fixed by #35694
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.

Comments

@Shinino
Copy link
Contributor

Shinino commented Nov 20, 2019

Describe the bug

The terminal settings (in Settings > Graphics) do not save. They also do not offer the option to save unless you also change something else -- but still does not save the terminal settings.

That said, resizing the window itself works, as does setting it to fullscreen and windowed borderless.

Steps To Reproduce

Steps to reproduce the behavior:
1: Start game
2: Choose Settings
3: Choose Options
4: Choose Graphics
5: Change anything on lines 9 and 10 (Terminal width and Terminal height)
6: Press escape to leave menu

Expected behavior

See a dialogue asking if I want to change settings. Once done, see settings applied in the options > graphics section. Once restarted, see changes take effect.

Versions and configuration

  • OS: Windows 10
  • Game Version: 0.D-9501-g41ef0cb
  • Graphics version: Tiles
  • Mods loaded: non-relevant, as before game actually begins.
@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. labels Nov 21, 2019
@RustyBrute
Copy link

RustyBrute commented Nov 22, 2019 •
edited
Loading

Same issue on android build 9221. And the game screen shrink to a tiny box on the corner of my phone.
Edit: I changed the options.json manualy and that solved the resolution problem.

@AMurkin AMurkin mentioned this issue Nov 23, 2019
Closed
@TheRealSnowman
Copy link

TheRealSnowman commented Nov 24, 2019 •
edited
Loading

Can confirm all of this so far as on build 9621 for android. I was hoping I didn't have to edit the file but I guess that's the workaround for now.

Tiny screen problem is dependent on exiting a seperately displayed menu (options, new game, world creation etc.) and going back to the title screen. Makes sense to say it's definitely using those default resolutions, but not stretching to fit the screen.

AMurkin added a commit to AMurkin/Cataclysm-DDA that referenced this issue Nov 24, 2019
@AMurkin
Replace handle_redraw calls with refresh calls
f38c174 
game_ui::init_ui() is doing much more than redrawing.
Discard handle_redraw().
Fixes CleverRaven#35631.
@AMurkin AMurkin mentioned this issue Nov 24, 2019
Merged
@ZhilkinSerg ZhilkinSerg mentioned this issue Nov 24, 2019
Closed
@weekly-digest weekly-digest bot mentioned this issue Nov 24, 2019
Closed
@ThomasLinkin
Copy link

yeah, i found the same problem guys. we only have one dev for the whole mobile platform,so it's must be hard to dealt with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed terminal settings saving AMurkin/Cataclysm-DDA
5 participants
@Night-Pryanik @RustyBrute @Shinino @TheRealSnowman @ThomasLinkin