Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Software Keyboard on Android 9.0 causes crashing [$20 Bounty] #33781

Closed
chriseich21 opened this issue Sep 3, 2019 · 67 comments · Fixed by #35209 or #35625
Closed

Opening Software Keyboard on Android 9.0 causes crashing [$20 Bounty] #33781

chriseich21 opened this issue Sep 3, 2019 · 67 comments · Fixed by #35209 or #35625
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. OS: Android Issues related to Android operating system (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@chriseich21
Copy link

chriseich21 commented Sep 3, 2019

Describe the bug

Inputting commands with the software Keyboard (SwiftKey) is frequently crashing on the 2nd attempt when using software back button/gesture on Note 9 and Android 9. It is impossible to trade more than a single item with a merchant (and there's a limit now on credit so you'll never be able to buy items over your credit limit if you do it one at a time)
Also a second, related bug, the software Keyboard numbers do not input any amount when picking up or dropping items. Not as bad though as using Advanced inventory to avoid dropping/picking up a full stack is possible.

Steps To Reproduce

  1. Spawn as Sheltered as a class with some decent items to sell (ex. Bionic Sniper)
  2. Input a letter/symbol of an item to buy on software Keyboard (opened with back key)
  3. Tab over to sell section and attempt to sell an item to cover cost by pressing back key to open the keyboard and crash the game.

Expected behavior

Somewhere prior to build 9569, or possibly prior to updating to Android 9.0 as it was similar timing, the software keyboard was working fine and it would work with the application just like a real hardware keyboard does. Ideally fixing the keyboard to work like a hardware one would be best, but I believe at one point the dynamic soft keys along the bottom of the screen showed items to buy/sell so that could be re-enabled/added.

Versions and configuration

  • OS: Android 9.0
  • Game Version: Build 9577 (version 0.D-7213-ga0159bf)
  • Graphics version: Tiles
  • Mods loaded: [DDA, CRIT Exp, Garden Pots, Makeshift Items, Medieval and Historic, More Survival Tools, Mythological Replicas, Dinomod, Modular Turrets, Salvaged Robots, Alt Map Key, EZ Medical, Hydroponics, Beta National Guard, More Locations, Fujis More Buildings, Urban Development, Folding Parts, Vehicle Additions, Tanks and Other, Necromancy]

Additional Context/Files

No crash.log is generated for this crash, however here is the debug.log.
debug.log

@gearforcer
Copy link

There are some compatibility problems, I guess.Recent builds run well on my Android 6.0 phone, and Android 9.0 seems occurs the issue.

@chriseich21 chriseich21 changed the title Software Keyboard on Android Build frequently crashing Opening Software Keyboard on Android Build causes crashing frequently Sep 3, 2019
@chriseich21
Copy link
Author

There are some compatibility problems, I guess.Recent builds run well on my Android 6.0 phone, and Android 9.0 seems occurs the issue.

Hm that's disappointing as it's my most played Android game. The timing does line up as the problem started after I updated to 9.0 but I didn't play for a couple days and downloaded a new build, but I didn't see anything in CDDA changelog that would appear to be causing the issue. Not sure if crash log generates just like PC but I can check and provide it for additional reference to hopefully assist with fixing and update my above post. Wonder what's causing the incompatibility in/with new Android version, if anyone finds out I'd be curious to know!

@chriseich21 chriseich21 changed the title Opening Software Keyboard on Android Build causes crashing frequently Opening Software Keyboard on Android 9.0 causes crashing frequently Sep 3, 2019
@gearforcer
Copy link

Maybe you can find some clues from this change log#9555,because it seems that there's no compatibility problems before Android experimental build 0.D-9562, check the download list for reference. You may ask @ZhilkinSerg for more information.

@ZhilkinSerg ZhilkinSerg added (S2 - Confirmed) Bug that's been confirmed to exist <Crash / Freeze> Fatal bug that results in hangs or crashes. OS: Android Issues related to Android operating system labels Sep 3, 2019
@gearforcer
Copy link

gearforcer commented Sep 6, 2019

@ZhilkinSerg On starting Android experimental build 0.D-9591-arm-v8a, it shows ERROR message. Run on andriod 9, CPU:Cortex A73+Cortex A53
Screenshot

@ZhilkinSerg
Copy link
Contributor

Which version are you on?

https://bugzilla.libsdl.org/show_bug.cgi?id=4316

@gearforcer
Copy link

Which version are you on?

https://bugzilla.libsdl.org/show_bug.cgi?id=4316

Andriod 9, CPU:Cortex A73+Cortex A53

@chriseich21
Copy link
Author

chriseich21 commented Sep 8, 2019

Mine had the same SDL error on Android 9 running on Note 9. I used the armeabi one and it launches like before but still has the same crashing problem when using software keyboard.

@gearforcer
Copy link

gearforcer commented Sep 8, 2019

Report more detail on forum may helpful.
https://discourse.cataclysmdda.org/t/android-version/13348/609

@chriseich21 chriseich21 changed the title Opening Software Keyboard on Android 9.0 causes crashing frequently Opening Software Keyboard on Android 9.0 causes crashing [$20 Bounty] Sep 13, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Sep 13, 2019
@Alprk1980
Copy link

I still have this issue too

@RustyBrute
Copy link

Same issue here. I am adding $10 to the bounty!

@chriseich21
Copy link
Author

I'll update the title to $30 when it shows up on bounty source

@ThomasLinkin
Copy link

Basically no one has found the error yet? Well shiet. I am seriously don't want to go back to the old 9310 version.

@Alprk1980
Copy link

9552 works as thats what I'm running in the meanwhile

@ThomasLinkin
Copy link

Thanks my dude. But that's the last version works for us?

@ZhilkinSerg
Copy link
Contributor

Thanks my dude. But that's the last version works for us?

Most probably build 9589

Basically no one has found the error yet? Well shiet. I am seriously don't want to go back to the old 9310 version.

Nobody tried yet.

@chriseich21
Copy link
Author

Well my bug report is on 9577

@ZhilkinSerg
Copy link
Contributor

Try 9552 then.

@ThomasLinkin
Copy link

9552 is the last one works btw.

@ThomasLinkin
Copy link

after that,none of them work. idk what, but it seems like the problem came from the device's OS

@ThomasLinkin
Copy link

i tried. the stable 0.D worked flawlessly, the experiment which Play Store allowed me to download was the #9310 version. so far the latest i could tried was the #9552 up here.

@gearforcer
Copy link

gearforcer commented Sep 30, 2019 via email

@Mrkeserian
Copy link

Okay, can confirm that the fix in the Google link hasn't been pushed to main, or if it was, it somehow didn't fix the issue. So, in conclusion, the Google drive version fixes that issue with the keyboard quite well.

@RustyBrute
Copy link

Same here. Keyboard issue fixed with g. link.

@ZhilkinSerg
Copy link
Contributor

Please try build 9845 and report id there are still issues with opening of keyboard.

@Mrkeserian
Copy link

Please try build 9845 and report id there are still issues with opening of keyboard.

Can confirm that crash on second keyboard open still exists for Build #9845. Galaxy S9+ Running Android 9.

@ZhilkinSerg
Copy link
Contributor

ZhilkinSerg commented Oct 31, 2019

Please test build 9847 (when it will be ready).

@RustyBrute
Copy link

No luck, I tested it and it crashes on second kboard activaion.

@ZhilkinSerg ZhilkinSerg reopened this Nov 1, 2019
@Mrkeserian
Copy link

Mrkeserian commented Nov 1, 2019

No luck, I tested it and it crashes on second kboard activaion.

I just tested it. And yep, no fix. Whatever was done to that Google drive release fixed it.

Edit: is there any way you could rebuild latest against a newer version of sdl and we could test that again? I'd do it, but I've never compiled Cata, don't have an environment set up, and have to go to work in five minutes.

@ZhilkinSerg
Copy link
Contributor

Please test build 9850 (when it will be ready).

@ThomasLinkin
Copy link

@ZhilkinSerg still there. The problem still exists.

@ZhilkinSerg
Copy link
Contributor

That is very strange. Are you sure https://drive.google.com/file/d/1-217DzMJJn-LOZiiHSvx5Xyk794S4Q7-/view?usp=drivesdk is working for fine you?

@ThomasLinkin
Copy link

Yeah. His game mod worked fine for me. Perfectly fine

@ThomasLinkin
Copy link

Oh and it seems like the game isn't compatible with Android 9 or st since every single bug or crash i saw happen on phones with Android 9

@Mrkeserian
Copy link

That is very strange. Are you sure https://drive.google.com/file/d/1-217DzMJJn-LOZiiHSvx5Xyk794S4Q7-/view?usp=drivesdk is working for fine you?

Yep. Only issue is that screen redraw issue, but it's easy to work around.

Oh and it seems like the game isn't compatible with Android 9 or st since every single bug or crash i saw happen on phones with Android 9

That's what I'm seeing as well. But again, the Google drive version with the updated sdl works fine. Didn't you mention that you had also changed an argument in the compile? Something about setting to android-16.

@Alprk1980
Copy link

Alprk1980 commented Nov 6, 2019

Also confirm that the apk from the drive fixes the keyboard issue running on android 9. But the latest compiled from the git doesn't.

@Mrkeserian
Copy link

So, if someone can link me to a guide for how to set up a compile for CDDA on Windows, I can try to compile with the updated includes and see what happens.

@Mrkeserian
Copy link

Sorry that I haven't been able to experiment with this so far this week, life and work have gotten in the way, but I may have some time to mess with it tonight or tomorrow. Either way, here's to hoping we can get a fix put together soon.

@ZhilkinSerg
Copy link
Contributor

Try version from here - https://www.dropbox.com/sh/oi4mrpfbwyzayqh/AABWAcefJ4qCH2NWtYyXPo12a?dl=0

@RustyBrute
Copy link

Try version from here - https://www.dropbox.com/sh/oi4mrpfbwyzayqh/AABWAcefJ4qCH2NWtYyXPo12a?dl=0

This works fine.

@ThomasLinkin
Copy link

@ZhilkinSerg now i have to face another problem. The game's screen shrank into a 1/10 size of the device's screen after i turn on the option tab and return to the main menu.

@ZhilkinSerg
Copy link
Contributor

@ThomasLinkin #35631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Crash / Freeze> Fatal bug that results in hangs or crashes. OS: Android Issues related to Android operating system (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet