Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsoleted mods #9310

Closed
wants to merge 1 commit into from
Closed

Remove obsoleted mods #9310

wants to merge 1 commit into from

Conversation

Lain-
Copy link
Contributor

@Lain- Lain- commented Sep 29, 2014

For 0.B eventual arrival.

@i2amroy
Copy link
Contributor

i2amroy commented Sep 29, 2014

This needs to have some sort of update to old save-games built in so that they don't generate missing mod messages on trying to load an old save.

@narc0tiq
Copy link
Contributor

Can we instead just have a property in the modinfo JSON that makes the mod hide from the new world screen? Then we can keep the obsoletes forever and not worry.

@i2amroy
Copy link
Contributor

i2amroy commented Oct 10, 2014

It would also still make our mod folder get full of old, obsolete mods over time. I'd think that a one line check that stores the id of each obsolete mod in save game processing would probably be preferable to having a mod folder filled with obsolete mods.

@kevingranade
Copy link
Member

or a list of obsolete mods in another json? :P

@narc0tiq
Copy link
Contributor

Hurr, list of obsolete mod names does sound easier. Probably data/mods/obsolete.json.

@KA101
Copy link
Contributor

KA101 commented Nov 4, 2014

OK, Lain et al, any word on this one?

@Lain-
Copy link
Contributor Author

Lain- commented Nov 4, 2014

Ah sorry I kinda forgot about this one. I'm busy these days so I don't think I can pursue this. Someone else will have to tackle this.

Feel free to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants