Merge pull request #36467 from Qrox/fix-use-after-free

Fix use-after-free in translations.cpp
CleverRaven · Dec 26, 2019 · 9a9104f · 9a9104f
2 parents 9e77218 + f1efb1a
commit 9a9104f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/translations.cpp b/src/translations.cpp
@@ -475,7 +475,8 @@ void translation::deserialize( JsonIn &jsin )
 #ifndef CATA_IN_TOOL
         if( test_mode ) {
             check_style = !jsobj.has_member( "//NOLINT(cata-text-style)" );
-            throw_error = [&jsobj]( const std::string & msg, const int offset ) {
+            // Copying jsobj to avoid use-after-free
+            throw_error = [jsobj]( const std::string & msg, const int offset ) {
                 jsobj.get_raw( "str" )->error( msg, offset );
             };
         }